QuicServer: Use Chrome's header parsing rather than Balsa

net/quic/quic_spdy_server_stream.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_QUIC_QUIC_SPDY_SERVER_STREAM_H_
 #define NET_QUIC_QUIC_SPDY_SERVER_STREAM_H_
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "net/base/io_buffer.h"
+#include "net/http/http_response_headers.h"

[wtc, 2014/06/25 22:22:24]

A forward declaration of class HttpResponseHeaders should be enough (because of
the change I suggest below).

[dmziegler, 2014/06/26 01:23:29]

Done.

 #include "net/quic/quic_data_stream.h"
 #include "net/quic/quic_protocol.h"
-#include "net/tools/balsa/balsa_headers.h"
+#include "url/gurl.h"
 
 namespace net {
 
 class QuicSession;
 
 namespace test {
 class QuicSpdyServerStreamPeer;
 }  // namespace test
 
 // All this does right now is aggregate data, and on fin, send an HTTP
@@ skipping 14 matching lines @@
   friend class test::QuicSpdyServerStreamPeer;
 
   // Sends a basic 200 response using SendHeaders for the headers and WriteData
   // for the body.
   void SendResponse();
 
   // Sends a basic 500 response using SendHeaders for the headers and WriteData
   // for the body
   void SendErrorResponse();
 
-  void SendHeadersAndBody(const BalsaHeaders& response_headers,
+  void SendHeadersAndBody(scoped_refptr<HttpResponseHeaders> response_headers,

[wtc, 2014/06/25 22:22:24]

Change this to
   const HttpResponseHeaders& response_headers,

Passing a scoped_refptr parameter implies transferring a reference to the
method.

[dmziegler, 2014/06/26 01:23:29]

Done.

                           base::StringPiece body);
 
-  BalsaHeaders headers_;
+  SpdyHeaderBlock headers_;
+  GURL request_url_;

[wtc, 2014/06/25 22:22:24]

Nit: move request_url_ forward, so that we don't separate headers_ and body_.

[dmziegler, 2014/06/26 01:23:29]

Done.

   string body_;
 
   // Buffer into which response header data is read.
   scoped_refptr<GrowableIOBuffer> read_buf_;
   bool request_headers_received_;
 
   DISALLOW_COPY_AND_ASSIGN(QuicSpdyServerStream);
 };
 
 }  // namespace net
 
 #endif  // NET_QUIC_QUIC_SPDY_SERVER_STREAM_H_