Source/modules/geolocation/GeolocationController.h - Issue 337053006: Oilpan: detach GeolocationController on being destroyed as a supplement.

Side by Side Diff: Source/modules/geolocation/GeolocationController.h

Issue 337053006: Oilpan: detach GeolocationController on being destroyed as a supplement. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2009 Apple Inc. All rights reserved.	2 * Copyright (C) 2009 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 virtual void trace(Visitor*) OVERRIDE;	73 virtual void trace(Visitor*) OVERRIDE;

74 virtual void willBeDestroyed() OVERRIDE;	74 virtual void willBeDestroyed() OVERRIDE;

75 virtual void persistentHostHasBeenDestroyed() OVERRIDE;	75 virtual void persistentHostHasBeenDestroyed() OVERRIDE;

76	76

77 private:	77 private:

78 GeolocationController(LocalFrame&, GeolocationClient*);	78 GeolocationController(LocalFrame&, GeolocationClient*);

79	79

80 void startUpdatingIfNeeded();	80 void startUpdatingIfNeeded();

81 void stopUpdatingIfNeeded();	81 void stopUpdatingIfNeeded();

82	82

	83 void detach();

	84

83 GeolocationClient* m_client;	85 GeolocationClient* m_client;

84 bool m_hasClientForTest;	86 bool m_hasClientForTest;

85	87

86 PersistentWillBeMember<GeolocationPosition> m_lastPosition;	88 PersistentWillBeMember<GeolocationPosition> m_lastPosition;

87 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation> > Observe rsSet;	89 typedef PersistentHeapHashSetWillBeHeapHashSet<Member<Geolocation> > Observe rsSet;

88 // All observers; both those requesting high accuracy and those not.	90 // All observers; both those requesting high accuracy and those not.

89 ObserversSet m_observers;	91 ObserversSet m_observers;

90 ObserversSet m_highAccuracyObservers;	92 ObserversSet m_highAccuracyObservers;

91 bool m_isClientUpdating;	93 bool m_isClientUpdating;

92 GeolocationInspectorAgent* m_inspectorAgent;	94 GeolocationInspectorAgent* m_inspectorAgent;
	haraken 2014/06/21 02:19:53 keishi@: You're moving the GeolocatoinInspectorAge keishi@: You're moving the GeolocatoinInspectorAgent to the heap in https://codereview.chromium.org/307943002/. This means that: - You need to change m_inspectorAgent a Member. - You need to remove the code that touches m_inspectorAgent from GeolocatoinInspectorAgent's destructor. (Doesn't ASAN detect the error?)
93 };	95 };

94	96

95 } // namespace WebCore	97 } // namespace WebCore

96	98

97 #endif // GeolocationController_h	99 #endif // GeolocationController_h

OLD	NEW

« no previous file with comments | « no previous file | Source/modules/geolocation/GeolocationController.cpp » ('j') | Source/modules/geolocation/GeolocationController.cpp » ('J')