Precache policy-for-extensions for device-local accounts.

chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/policy/device_local_account_policy_service.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
 #include "base/file_util.h"
@@ skipping 395 matching lines @@
                        _))
       .WillOnce(SaveArg<6>(&request));
   // This will be called twice, because the ComponentCloudPolicyService will
   // also become ready after flushing all the pending tasks.
   EXPECT_CALL(service_observer_, OnPolicyUpdated(account_1_user_id_)).Times(2);
   broker->core()->client()->FetchPolicy();
   FlushDeviceSettings();
   Mock::VerifyAndClearExpectations(&service_observer_);
   Mock::VerifyAndClearExpectations(&mock_device_management_service_);
   EXPECT_TRUE(request.has_policy_request());
-  EXPECT_EQ(1, request.policy_request().request_size());
+  ASSERT_EQ(2, request.policy_request().request_size());
+
+  const em::PolicyFetchRequest* public_account =

[bartfab (slow), 2014/06/23 09:53:37]

Nit: #include "policy/proto/device_management_backend.pb.h"

[Joao da Silva, 2014/07/16 11:47:52]

Done.

+      &request.policy_request().request(0);
+  const em::PolicyFetchRequest* extensions =
+      &request.policy_request().request(1);
+  // The order is not guarateed.
+  if (extensions->policy_type() ==
+      dm_protocol::kChromePublicAccountPolicyType) {
+    const em::PolicyFetchRequest* tmp = public_account;

[bartfab (slow), 2014/06/23 09:53:37]

Nit: Use std::swap() from <algorithm>

[Joao da Silva, 2014/07/16 11:47:52]

Done.

+    public_account = extensions;
+    extensions = tmp;
+  }
+
   EXPECT_EQ(dm_protocol::kChromePublicAccountPolicyType,
-            request.policy_request().request(0).policy_type());
-  EXPECT_FALSE(request.policy_request().request(0).has_machine_id());
-  EXPECT_EQ(kAccount1,
-            request.policy_request().request(0).settings_entity_id());
+            public_account->policy_type());
+  EXPECT_FALSE(public_account->has_machine_id());
+  EXPECT_EQ(kAccount1, public_account->settings_entity_id());
+
+  EXPECT_EQ(dm_protocol::kChromeExtensionPolicyType,
+            extensions->policy_type());
+  EXPECT_FALSE(extensions->has_machine_id());
+  EXPECT_FALSE(extensions->has_settings_entity_id());
 
   ASSERT_TRUE(broker->core()->store());
   EXPECT_EQ(CloudPolicyStore::STATUS_OK,
             broker->core()->store()->status());
   ASSERT_TRUE(broker->core()->store()->policy());
   EXPECT_EQ(device_local_account_policy_.policy_data().SerializeAsString(),
             broker->core()->store()->policy()->SerializeAsString());
   EXPECT_TRUE(expected_policy_map_.Equals(
       broker->core()->store()->policy_map()));
   EXPECT_TRUE(service_->IsPolicyAvailableForUser(account_1_user_id_));
@@ skipping 516 matching lines @@
   em::DeviceManagementResponse response;
   device_local_account_policy_.Build();
   response.mutable_policy_response()->add_response()->CopyFrom(
       device_local_account_policy_.policy());
   request_job->SendResponse(DM_STATUS_SUCCESS, response);
   FlushDeviceSettings();
   Mock::VerifyAndClearExpectations(&provider_observer_);
 }
 
 }  // namespace policy