Source/devtools/front_end/timeline/TimelineModelImpl.js - Issue 337023004: Don't create TimelineModel.RecordImpl in TimelinePresentationModel.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/devtools/front_end/timeline/TimelineModelImpl.js

Issue 337023004: Don't create TimelineModel.RecordImpl in TimelinePresentationModel.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Addressed comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/devtools/front_end/timeline/TimelineModelImpl.js

diff --git a/Source/devtools/front_end/timeline/TimelineModelImpl.js b/Source/devtools/front_end/timeline/TimelineModelImpl.js

index 3422c2398ccaa058f3b943635fddc542135f3e8b..17651c7d9a6921746661958f532edf12a4e2d971 100644

--- a/Source/devtools/front_end/timeline/TimelineModelImpl.js

+++ b/Source/devtools/front_end/timeline/TimelineModelImpl.js

@@ -162,7 +162,6 @@ WebInspector.TimelineModelImpl.prototype = {

* @param {!TimelineAgent.TimelineEvent} payload

* @param {?WebInspector.TimelineModel.Record} parentRecord

* @return {!WebInspector.TimelineModel.Record}

- * @this {!WebInspector.TimelineModel}

_innerAddRecord: function(payload, parentRecord)

{

@@ -290,7 +289,7 @@ WebInspector.TimelineModelImpl.InterRecordBindings.prototype = {

/**

* @constructor

* @implements {WebInspector.TimelineModel.Record}

- * @param {!WebInspector.TimelineModel} model

+ * @param {!WebInspector.TimelineModelImpl} model

* @param {!TimelineAgent.TimelineEvent} timelineEvent

* @param {?WebInspector.TimelineModel.Record} parentRecord