Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: Source/devtools/front_end/timeline/TimelineJSProfile.js

Issue 337023004: Don't create TimelineModel.RecordImpl in TimelinePresentationModel.js (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Addressed comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 5
6 WebInspector.TimelineJSProfileProcessor = { }; 6 WebInspector.TimelineJSProfileProcessor = { };
7 7
8 /** 8 /**
9 * @param {!WebInspector.TimelineModel} timelineModel 9 * @param {!WebInspector.TimelineModelImpl} timelineModel
10 * @param {!ProfilerAgent.CPUProfile} jsProfile 10 * @param {!ProfilerAgent.CPUProfile} jsProfile
11 */ 11 */
12 WebInspector.TimelineJSProfileProcessor.mergeJSProfileIntoTimeline = function(ti melineModel, jsProfile) 12 WebInspector.TimelineJSProfileProcessor.mergeJSProfileIntoTimeline = function(ti melineModel, jsProfile)
13 { 13 {
14 if (!jsProfile.samples) 14 if (!jsProfile.samples)
15 return; 15 return;
16 var jsProfileModel = new WebInspector.CPUProfileDataModel(jsProfile); 16 var jsProfileModel = new WebInspector.CPUProfileDataModel(jsProfile);
17 var idleNode = jsProfileModel.idleNode; 17 var idleNode = jsProfileModel.idleNode;
18 var programNode = jsProfileModel.programNode; 18 var programNode = jsProfileModel.programNode;
19 var gcNode = jsProfileModel.gcNode; 19 var gcNode = jsProfileModel.gcNode;
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 record.children().push(child); 83 record.children().push(child);
84 } 84 }
85 } 85 }
86 86
87 jsProfileModel.forEachFrame(onOpenFrame, onCloseFrame, recordStartTime, recordEndTime); 87 jsProfileModel.forEachFrame(onOpenFrame, onCloseFrame, recordStartTime, recordEndTime);
88 putOriginalChildrenUpToTime(recordEndTime); 88 putOriginalChildrenUpToTime(recordEndTime);
89 } 89 }
90 90
91 timelineModel.forAllRecords(processRecord); 91 timelineModel.forAllRecords(processRecord);
92 } 92 }
OLDNEW
« no previous file with comments | « Source/devtools/front_end/timeline/TimelineFlameChart.js ('k') | Source/devtools/front_end/timeline/TimelineModelImpl.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698