Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 337023004: Don't create TimelineModel.RecordImpl in TimelinePresentationModel.js (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
caseq, alph, pfeldman1, loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Don't create TimelineModel.RecordImpl in TimelinePresentationModel.js TimelinePresentationModel.Record now has three implementations: one for root record, one for coealesced record and one for representing actual TimelineModel.Record. This allows it to work fine with Timeline based on trace events. BUG=361045 R=caseq@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176205

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -64 lines) Patch
M LayoutTests/http/tests/inspector/timeline-test.js View 1 2 chunks +6 lines, -5 lines 0 comments Download
M LayoutTests/inspector/timeline/timeline-coalescing.html View 1 2 chunks +5 lines, -5 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineFlameChart.js View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineJSProfile.js View 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/timeline/TimelineModelImpl.js View 2 chunks +1 line, -2 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelinePresentationModel.js View 1 2 14 chunks +221 lines, -40 lines 0 comments Download
M Source/devtools/front_end/timeline/TimelineView.js View 7 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
yurys
6 years, 6 months ago (2014-06-16 08:35:50 UTC) #1
caseq
https://codereview.chromium.org/337023004/diff/20001/Source/devtools/front_end/timeline/TimelinePresentationModel.js File Source/devtools/front_end/timeline/TimelinePresentationModel.js (right): https://codereview.chromium.org/337023004/diff/20001/Source/devtools/front_end/timeline/TimelinePresentationModel.js#newcode193 Source/devtools/front_end/timeline/TimelinePresentationModel.js:193: var record = presentationRecord; nit: remove this and inline ...
6 years, 6 months ago (2014-06-16 12:26:33 UTC) #2
caseq
lgtm
6 years, 6 months ago (2014-06-16 12:28:06 UTC) #3
yurys
https://codereview.chromium.org/337023004/diff/20001/Source/devtools/front_end/timeline/TimelinePresentationModel.js File Source/devtools/front_end/timeline/TimelinePresentationModel.js (right): https://codereview.chromium.org/337023004/diff/20001/Source/devtools/front_end/timeline/TimelinePresentationModel.js#newcode193 Source/devtools/front_end/timeline/TimelinePresentationModel.js:193: var record = presentationRecord; On 2014/06/16 12:26:33, caseq wrote: ...
6 years, 6 months ago (2014-06-16 12:32:37 UTC) #4
yurys
6 years, 6 months ago (2014-06-16 12:44:37 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 manually as r176205 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698