Fixed app shortcut creation broken in r276419

Fixed app shortcut creation broken in r276419

App shortcuts were being created without the shortcut_info parameter,
so web_app::CreateShortcutsForShortcutInfo() was being called with an
empty app ID and shortcut icon. Partially reverted r276419 to load the
app info properly when creating app shortcuts.

BUG=384240
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277726

[Matt Giuca, 2014-06-16 00:05:12]

lgtm

Your CL description is not very clear about the situation here. My first reading
of it makes it seem like r276419 removed something that was no longer needed,
and now it is needed, so you are putting it back (possibly because in the future
you will need that app info). The actual case is more dire: r276419 broke app
shortcut creation, and so you are partially reverting it. My suggestion:

"Fixed app shortcut creation broken in r276419.

App shortcuts were being created without the --app-id parameter <explain the
exact situation here>. Partially reverted r276419 to load the app info properly
when creating app shortcuts."

[sashab, 2014-06-16 00:21:23]

Sorry Ben; sky@ is a more appropriate reviewer for this because he originally
reviewed r276419 :) Thanks.

[sky, 2014-06-16 14:43:06]

LGTM

[sashab, 2014-06-16 22:34:04]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2014-06-16 22:45:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sashab@chromium.org/337023002/1

[commit-bot: I haz the power, 2014-06-17 11:24:14]

Change committed as 277726