Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1597)

Unified Diff: remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java

Issue 337013002: Third Party Authentication for Android Part III - Android OAuth2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CL feedbacks Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
diff --git a/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java b/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
index 81e94ccd9de4202caf5cedb919bfd7be3986b894..c8505516e6dbd3f4d973d572829577bc3d666152 100644
--- a/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
+++ b/remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java
@@ -21,6 +21,7 @@ import android.widget.TextView;
import org.chromium.base.CalledByNative;
import org.chromium.base.JNINamespace;
+import org.chromium.chromoting.Chromoting;
import org.chromium.chromoting.R;
import java.nio.ByteBuffer;
@@ -434,14 +435,15 @@ public class JniInterface {
/** Returns the current cursor shape. Called on the graphics thread. */
public static Bitmap getCursorBitmap() { return sCursorBitmap; }
- /**
- * Third Party Authentication
- */
+ //
+ // Third Party Authentication
+ //
+
/** Pops up a third party login page to fetch the token required for authentication.*/
Lambros 2014/06/17 02:01:40 Space after '.'
kelvinp 2014/06/17 03:33:40 Done.
@CalledByNative
public static void fetchThirdPartyToken(String tokenUrl, String clientId, String scope) {
- // TODO(kelvinp): Create a intent to fetch the token from the browser
- // (Android Third Party Auth - Part III)
+ Chromoting app = (Chromoting) sContext;
+ app.fetchThirdPartyToken(tokenUrl, clientId, scope);
}
/* Notify the native code to continue authentication with the |token| and the |sharedSecret| */

Powered by Google App Engine
This is Rietveld 408576698