Issue 336953002: Revise unittest for 'AR' in 'make_global_settings'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336953002: Revise unittest for 'AR' in 'make_global_settings' (Closed)

Created:
6 years, 6 months ago by yukawa

Modified:
6 years, 6 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com, Torne, Ami GONE FROM CHROMIUM

Base URL:
http://gyp.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revise unittest for 'AR' in 'make_global_settings' This is a follow up CL for r1931 and r1935. This is just a revise of a unittest and does not changes existing functionality. It turned out that we need to specify GYP_CROSSCOMPILE=1 to test 'AR'/'AR.host' properly. Expected results, which correspond to the current behavior atually, are updated accordingly. BUG=gyp:434 TEST=unittest R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1940

Patch Set 1 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -12 lines)			Patch
	M	test/make_global_settings/ar/gyptest-make_global_settings_ar.py	View		2 chunks	+14 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yukawa

Hi Scott. This is a 'AR' version of gyp r1939. Can you take a look?

6 years, 6 months ago (2014-06-14 16:37:03 UTC) #1

yukawa

6 years, 6 months ago (2014-06-16 16:09:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r1940 (presubmit successful).

Expand Messages | Collapse Messages