device/bluetooth: Introduce BluetoothGattConnection.

device/bluetooth: Introduce BluetoothGattConnection.

This patch introduces the abstract API definitions for BluetoothGattConnection
and BluetoothDevice::CreateGattConnection, which are used to manage the life
time of a GATT connection among multiple apps that request it.

BUG=384620
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278197

[keybuk, 2014-06-17 21:36:23]

+isherman for _mac OWNERS
+rpaquay, xiyuan for _win

[xiyuan, 2014-06-17 21:38:58]

_win LGTM

[keybuk, 2014-06-17 21:41:06]

lgtm

https://codereview.chromium.org/336933002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_gatt_connection.h (right):

https://codereview.chromium.org/336933002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_gatt_connection.h:28: virtual bool IsActive() const =
0;
nit: "Connected" makes much more sense than "Active"

[Ilya Sherman, 2014-06-17 21:53:48]

_mac LGTM, thanks.

https://codereview.chromium.org/336933002/diff/40001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_device_mac.mm (right):

https://codereview.chromium.org/336933002/diff/40001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_device_mac.mm:226: error_callback.Run(ERROR_UNKNOWN);
nit: Do you think it's worth having an ERROR_UNIMPLEMENTED, so that an app
developer gets a clearer message as to what's gone wrong?

[armansito, 2014-06-18 02:03:06]

https://codereview.chromium.org/336933002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_gatt_connection.h (right):

https://codereview.chromium.org/336933002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_gatt_connection.h:28: virtual bool IsActive() const =
0;
On 2014/06/17 21:41:06, keybuk wrote:
> nit: "Connected" makes much more sense than "Active"

Done.

https://codereview.chromium.org/336933002/diff/40001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_device_mac.mm (right):

https://codereview.chromium.org/336933002/diff/40001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_device_mac.mm:226: error_callback.Run(ERROR_UNKNOWN);
On 2014/06/17 21:53:48, Ilya Sherman wrote:
> nit: Do you think it's worth having an ERROR_UNIMPLEMENTED, so that an app
> developer gets a clearer message as to what's gone wrong?

hmm, I'm not sure if ConnectErrorCode is the correct enum for that. I guess it
is a valid connect error since we have two platforms now that won't implement
this function any time soon. We can always remove it later once it is all
implemented.

[armansito, 2014-06-18 02:03:10]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-06-18 02:05:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/armansito@chromium.org/336933002/60001

[commit-bot: I haz the power, 2014-06-18 05:41:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-18 05:41:39]

Try jobs failed on following builders:
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/18232)

[armansito, 2014-06-18 18:13:51]

The CQ bit was checked by armansito@chromium.org

[commit-bot: I haz the power, 2014-06-18 18:16:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/armansito@chromium.org/336933002/120001

[commit-bot: I haz the power, 2014-06-18 23:49:03]

Change committed as 278197