Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 336893002: Qualify the generated includes in core (part 3) (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews, kenneth.christiansen, philipj_slow, gavinp+prerender_chromium.org, tzik, eric.carlson_apple.com, blink-reviews-html_chromium.org, gasubic, fs, nhiroki, vcarbune.chromium, feature-media-reviews_chromium.org, dglazkov+blink, nessy, gavinp+loader_chromium.org, Nate Chapin, kinuko+fileapi
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Qualify the generated includes in core (part 3) This CL takes care the fetch, fileapi, frame and part of html subdirs under core. BUG=381876 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176158

Patch Set 1 #

Patch Set 2 : Rebaseline. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -190 lines) Patch
M Source/core/fetch/FontResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ImageResource.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/fetch/XSLStyleSheetResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fileapi/FileReaderLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/DOMWindow.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/ImageBitmapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/LocalFrame.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/frame/PinchViewport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Settings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/Settings.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/html/ClassList.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/DocumentNameCollection.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/FormAssociatedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAppletElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAreaElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLAudioElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBRElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLBaseElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLBodyElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLButtonElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLContentElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLDListElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDataListElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDetailsElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDirectoryElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLDivElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLElement.cpp View 1 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLEmbedElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLFieldSetElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFontElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFormElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameElementBase.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLFrameSetElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLHRElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLHeadElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLHtmlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLIFrameElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImageElement.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/html/HTMLImageLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLInputElement.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLKeygenElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLIElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLLabelElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLegendElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLLinkElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMapElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMarqueeElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMenuElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLMetaElement-in.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMeterElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLModElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLNoEmbedElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLNoScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOListElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLObjectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptGroupElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOptionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLOutputElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLParagraphElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLParamElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPictureElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLPlugInElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLPreElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLProgressElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLQuoteElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLRTElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLRubyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLScriptElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSelectElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLShadowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSourceElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSpanElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLStyleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLSummaryElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableCaptionElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableCellElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableColElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTableElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTablePartElement.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLTableRowElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableRowsCollection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTableSectionElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextAreaElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTitleElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLUListElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLVideoElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLViewSourceDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLWBRElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/ImageDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LabelsNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/LinkResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/MediaDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/PluginDocument.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/RadioNodeList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/AtomicHTMLToken.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/CSSPreloadScanner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLElementStack.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLMetaCharsetParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLParserIdioms.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLSrcsetParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLStackItem.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLTokenizer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 chunk +6 lines, -6 lines 0 comments Download
M Source/core/html/parser/HTMLTreeBuilderSimulator.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/parser/TextDocumentParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/TextResourceDecoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/XSSAuditor.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
c.shu
6 years, 6 months ago (2014-06-13 22:00:36 UTC) #1
haraken
rubberstamp LGTM.
6 years, 6 months ago (2014-06-14 00:32:51 UTC) #2
c.shu
On 2014/06/14 00:32:51, haraken wrote: > rubberstamp LGTM. thanks for taking care of this all ...
6 years, 6 months ago (2014-06-14 00:55:02 UTC) #3
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-14 00:55:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/336893002/1
6 years, 6 months ago (2014-06-14 00:55:48 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-14 01:38:45 UTC) #6
commit-bot: I haz the power
Failed to apply patch for Source/core/html/HTMLMetaElement-in.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 6 months ago (2014-06-14 01:38:47 UTC) #7
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-14 19:55:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/336893002/20001
6 years, 6 months ago (2014-06-14 19:56:37 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 21:50:12 UTC) #10
Message was sent while issue was closed.
Change committed as 176158

Powered by Google App Engine
This is Rietveld 408576698