Issue 336863007: Parser: add usage counters for "use asm".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336863007: Parser: add usage counters for "use asm". (Closed)

Created:
6 years, 5 months ago by marja

Modified:
6 years, 5 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
Paweł Hajdan Jr., v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Parser: add usage counters for "use asm". R=jochen@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=22093

Patch Set 2 : code review (jochen@) #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -3 lines)			Patch
M	include/v8.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ast-value-factory.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/parser.h	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/parser.cc	View		5 chunks	+28 lines, -2 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View		1 chunk	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

lgtm https://codereview.chromium.org/336863007/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/336863007/diff/1/include/v8.h#newcode4138 include/v8.h:4138: kUseCounterFeatureCount can you add a comment similar to ...

6 years, 5 months ago (2014-06-30 13:23:21 UTC) #1

marja

tfr https://codereview.chromium.org/336863007/diff/1/include/v8.h File include/v8.h (right): https://codereview.chromium.org/336863007/diff/1/include/v8.h#newcode4138 include/v8.h:4138: kUseCounterFeatureCount On 2014/06/30 13:23:21, jochen wrote: > can ...

6 years, 5 months ago (2014-06-30 13:25:25 UTC) #2

marja

6 years, 5 months ago (2014-06-30 13:35:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22093 (presubmit successful).

Expand Messages | Collapse Messages

Issue 336863007: Parser: add usage counters for "use asm". (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review (jochen@) #

Messages