Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336823002: [DeviceLight] Add Layout support (Closed)

Created:
6 years, 6 months ago by riju_
Modified:
6 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[DeviceLight] Add Layout support Adds the necessary plumbing to make it possible to test the blink implementation of DeviceLight API using Layout Tests and TestRunner. This is part 3 of the Adding Device Light [content side] BUG=336424 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280626

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : Add ResetDeviceLight #

Patch Set 4 : remove unrelated changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
M content/public/test/layouttest_support.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/WebTestDelegate.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/test_runner.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 1 2 3 5 chunks +24 lines, -0 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/webkit_test_runner.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
riju_
6 years, 6 months ago (2014-06-13 17:03:45 UTC) #1
riju_
Layout support for Device Light as discussed here -> https://codereview.chromium.org/286793002/diff/280001/content/renderer/renderer_webkitplatformsupport_impl.h#newcode179
6 years, 6 months ago (2014-06-25 15:52:36 UTC) #2
jochen (gone - plz use gerrit)
can you reset the device light data after each test (e.g. in TestRunner::Reset) https://codereview.chromium.org/336823002/diff/20001/content/shell/renderer/test_runner/test_runner.cc File ...
6 years, 6 months ago (2014-06-26 14:59:14 UTC) #3
riju_
https://codereview.chromium.org/336823002/diff/20001/content/shell/renderer/test_runner/test_runner.cc File content/shell/renderer/test_runner/test_runner.cc (right): https://codereview.chromium.org/336823002/diff/20001/content/shell/renderer/test_runner/test_runner.cc#newcode408 content/shell/renderer/test_runner/test_runner.cc:408: .SetMethod("resetBatteryStatus", &TestRunnerBindings::ResetBatteryStatus) On 2014/06/26 14:59:14, jochen wrote: > unrelated ...
6 years, 5 months ago (2014-06-28 00:20:07 UTC) #4
jochen (gone - plz use gerrit)
yes, please remove the unrelated changes from this CL I'm happy to approve a separate ...
6 years, 5 months ago (2014-06-30 11:57:03 UTC) #5
riju_
On 2014/06/30 11:57:03, jochen wrote: > yes, please remove the unrelated changes from this CL ...
6 years, 5 months ago (2014-06-30 12:21:03 UTC) #6
riju_
The CQ bit was checked by rijubrata.bhaumik@intel.com
6 years, 5 months ago (2014-06-30 12:21:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rijubrata.bhaumik@intel.com/336823002/100001
6 years, 5 months ago (2014-06-30 12:21:57 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...
6 years, 5 months ago (2014-06-30 16:06:54 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-06-30 17:44:24 UTC) #10
Message was sent while issue was closed. 
Change committed as 280626

Powered by Google App Engine
This is Rietveld 408576698