cc: Move CalculateContentsScale from LayerImpl to LayerTreeHostCommon

cc: Move CalculateContentsScale from LayerImpl to LayerTreeHostCommon

This is mainly plumbing code.
As we no longer have CalculateContentsScale for PictureLayerImpl,we
move the scale calculations to LTHCommon.
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277055

[sohanjg, 2014-06-13 14:07:23]

Can you please take a look.
Thanks.

[danakj, 2014-06-13 15:00:27]

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
File cc/trees/layer_tree_host_common.cc (right):

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
cc/trees/layer_tree_host_common.cc:942:
layer->draw_properties().contents_scale_x = layer->contents_scale_x();
This is just setting x=x; which we don't need to do. You can just leave this
method completely empty, and steal the comment from LayerImpl about how we push
content scales from the main thread?

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
cc/trees/layer_tree_host_common.cc:966: static inline void
CalculateContentsScale(
blank line between methods

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
cc/trees/layer_tree_host_common_unittest.cc:7869: virtual void
CalculateContentsScale(float ideal_contents_scale,
Can just remove this method? It's not overriding anything anymore, clang should
complain about it.

[sohanjg, 2014-06-13 15:36:06]

Please take a look.
Thanks.

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
File cc/trees/layer_tree_host_common.cc (right):

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
cc/trees/layer_tree_host_common.cc:942:
layer->draw_properties().contents_scale_x = layer->contents_scale_x();
On 2014/06/13 15:00:27, danakj wrote:
> This is just setting x=x; which we don't need to do. You can just leave this
> method completely empty, and steal the comment from LayerImpl about how we
push
> content scales from the main thread?

Done.

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
cc/trees/layer_tree_host_common.cc:966: static inline void
CalculateContentsScale(
On 2014/06/13 15:00:27, danakj wrote:
> blank line between methods

Done.

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
File cc/trees/layer_tree_host_common_unittest.cc (right):

https://codereview.chromium.org/336793003/diff/1/cc/trees/layer_tree_host_com...
cc/trees/layer_tree_host_common_unittest.cc:7869: virtual void
CalculateContentsScale(float ideal_contents_scale,
On 2014/06/13 15:00:27, danakj wrote:
> Can just remove this method? It's not overriding anything anymore, clang
should
> complain about it.

Done.

[danakj, 2014-06-13 15:39:10]

LGTM

[danakj, 2014-06-13 15:39:12]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2014-06-13 15:39:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/sohan.jyoti@samsung.com/336793003/20001

[enne (OOO), 2014-06-13 17:30:31]

This is super great.  Thank you!  lgtm2

[commit-bot: I haz the power, 2014-06-13 18:15:44]

Change committed as 277055

[sohanjg, 2015-11-18 09:36:14]

Description was changed from

==========
cc: Move CalculateContentsScale from LayerImpl to LayerTreeHostCommon

This is mainly plumbing code.
As we no longer have CalculateContentsScale for PictureLayerImpl,we
move the scale calculations to LTHCommon.
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277055
==========

to

==========
cc: Move CalculateContentsScale from LayerImpl to LayerTreeHostCommon

This is mainly plumbing code.
As we no longer have CalculateContentsScale for PictureLayerImpl,we
move the scale calculations to LTHCommon.
BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277055
==========