runtime/vm/intermediate_language.cc - Issue 336773003: More precise range analysis for smi multiplication.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language.cc

Issue 336773003: More precise range analysis for smi multiplication. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language.cc

===================================================================

--- runtime/vm/intermediate_language.cc (revision 37311)

+++ runtime/vm/intermediate_language.cc (working copy)

@@ -3087,7 +3087,9 @@

case Token::kMUL: {

const int64_t left_max = ConstantAbsMax(left_range);

const int64_t right_max = ConstantAbsMax(right_range);

- if ((left_max < 0x7FFFFFFF) && (right_max < 0x7FFFFFFF)) {

+ ASSERT(left_max <= -kSmiMin);

+ ASSERT(right_max <= -kSmiMin);

+ if ((left_max == 0) || (right_max <= kMaxInt64 / left_max)) {

// Product of left and right max values stays in 64 bit range.

const int64_t result_max = left_max * right_max;

if (Smi::IsValid64(result_max) && Smi::IsValid64(-result_max)) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »