Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc

Issue 336763002: Password internals page: notify renderer about logging state on client construction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a ping message renderer->browser for logging activity update Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
index 87c2239d37b8ab5d3c4a1de88286412bb21a4189..444676d21cf163d93f9d867aea2a6c93a431fd41 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
@@ -137,6 +137,35 @@ TEST_F(ChromePasswordManagerClientTest, LogSavePasswordProgressNotifyRenderer) {
EXPECT_FALSE(logging_active);
}
+TEST_F(ChromePasswordManagerClientTest, AnswerToPingsAboutLoggingState_Active) {
+ service_->RegisterReceiver(&receiver_);
+
+ process()->sink().ClearMessages();
+
+ // Ping the client for logging activity update.
+ AutofillHostMsg_UpdateLoggingState msg(0);
+ static_cast<IPC::Listener*>(GetClient())->OnMessageReceived(msg);
+
+ bool logging_active = false;
+ EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_active));
+ EXPECT_TRUE(logging_active);
+
+ service_->UnregisterReceiver(&receiver_);
+}
+
+TEST_F(ChromePasswordManagerClientTest,
+ AnswerToPingsAboutLoggingState_Inactive) {
+ process()->sink().ClearMessages();
+
+ // Ping the client for logging activity update.
+ AutofillHostMsg_UpdateLoggingState msg(0);
+ static_cast<IPC::Listener*>(GetClient())->OnMessageReceived(msg);
+
+ bool logging_active = true;
+ EXPECT_TRUE(WasLoggingActivationMessageSent(&logging_active));
+ EXPECT_FALSE(logging_active);
+}
+
TEST_F(ChromePasswordManagerClientTest,
IsAutomaticPasswordSavingEnabledDefaultBehaviourTest) {
EXPECT_FALSE(GetClient()->IsAutomaticPasswordSavingEnabled());

Powered by Google App Engine
This is Rietveld 408576698