components/autofill/content/common/autofill_messages.h - Issue 336763002: Password internals page: notify renderer about logging state on client construction

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_messages.h

Issue 336763002: Password internals page: notify renderer about logging state on client construction (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments addressed Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/autofill/password_autofill_agent_browsertest.cc ('k') | components/autofill/content/renderer/password_autofill_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_messages.h

diff --git a/components/autofill/content/common/autofill_messages.h b/components/autofill/content/common/autofill_messages.h

index f9a99fe670dea7fccaf93328f7517227906990e1..4eff7e98f67e4ed14ac0d3062c08d39160dd8597 100644

--- a/components/autofill/content/common/autofill_messages.h

+++ b/components/autofill/content/common/autofill_messages.h

@@ -117,7 +117,7 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_FillPasswordForm,

// Notification to start (|active| == true) or stop (|active| == false) logging

// the decisions made about saving the password.

-IPC_MESSAGE_ROUTED1(AutofillMsg_ChangeLoggingState, bool /* active */)

+IPC_MESSAGE_ROUTED1(AutofillMsg_SetLoggingState, bool /* active */)

// Send the heuristic and server field type predictions to the renderer.

IPC_MESSAGE_ROUTED1(

@@ -199,6 +199,11 @@ IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsParsed,

IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormsRendered,

std::vector<autofill::PasswordForm> /* forms */)

+// A ping to the browser that PasswordAutofillAgent was constructed. As a

+// consequence, the browser sends AutofillMsg_SetLoggingState with the current

+// state of the logging activity.

+IPC_MESSAGE_ROUTED0(AutofillHostMsg_PasswordAutofillAgentConstructed);

// Notification that this password form was submitted by the user.

IPC_MESSAGE_ROUTED1(AutofillHostMsg_PasswordFormSubmitted,

autofill::PasswordForm /* form */)