Password internals page: notify renderer about logging state on client construction

chrome/browser/password_manager/chrome_password_manager_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/memory/singleton.h"
 #include "base/metrics/histogram.h"
@@ skipping 171 matching lines @@
   }
   return false;
 }
 
 void ChromePasswordManagerClient::OnLogRouterAvailabilityChanged(
     bool router_can_be_used) {
   if (can_use_log_router_ == router_can_be_used)
     return;
   can_use_log_router_ = router_can_be_used;
 
-  if (!web_contents())
-    return;
-
-  // Also inform the renderer process to start or stop logging.
-  web_contents()->GetRenderViewHost()->Send(new AutofillMsg_ChangeLoggingState(
-      web_contents()->GetRenderViewHost()->GetRoutingID(),
-      can_use_log_router_));
+  NotifyRendererAboutLoggingActivityState();
 }
 
 void ChromePasswordManagerClient::LogSavePasswordProgress(
     const std::string& text) {
   if (!IsLoggingActive())
     return;
   PasswordManagerInternalsService* service =
       PasswordManagerInternalsServiceFactory::GetForBrowserContext(profile_);
   if (service)
     service->ProcessLog(text);
@@ skipping 35 matching lines @@
 bool ChromePasswordManagerClient::OnMessageReceived(
     const IPC::Message& message) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(ChromePasswordManagerClient, message)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_ShowPasswordGenerationPopup,
                         ShowPasswordGenerationPopup)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_ShowPasswordEditingPopup,
                         ShowPasswordEditingPopup)
     IPC_MESSAGE_HANDLER(AutofillHostMsg_HidePasswordGenerationPopup,
                         HidePasswordGenerationPopup)
+    IPC_MESSAGE_HANDLER(AutofillHostMsg_UpdateLoggingState,
+                        NotifyRendererAboutLoggingActivityState)
     IPC_MESSAGE_UNHANDLED(handled = false)
   IPC_END_MESSAGE_MAP()
   return handled;
 }
 
 gfx::RectF ChromePasswordManagerClient::GetBoundsInScreenSpace(
     const gfx::RectF& bounds) {
   gfx::Rect client_area = web_contents()->GetContainerBounds();
   return bounds + client_area.OffsetFromOrigin();
 }
@@ skipping 35 matching lines @@
           form,
           0,  // Unspecified max length.
           driver_.GetPasswordManager(),
           observer_,
           web_contents(),
           web_contents()->GetNativeView());
   popup_controller_->Show(false /* display_password */);
 #endif  // defined(USE_AURA) || defined(OS_MACOSX)
 }
 
+void ChromePasswordManagerClient::NotifyRendererAboutLoggingActivityState() {

[Ilya Sherman, 2014/06/14 00:50:39]

Optional nit: "About" -> "Of" for a slightly shorter method name.

[vabr (Chromium), 2014/06/20 10:47:04]

Done.

+  if (!web_contents())
+    return;
+
+  // Also inform the renderer process to start or stop logging.

[Ilya Sherman, 2014/06/14 00:50:39]

nit: Please update this comment.

[vabr (Chromium), 2014/06/20 10:47:04]

Done. (Removed, since the whole method is just for notifying the renderer.)

+  web_contents()->GetRenderViewHost()->Send(new AutofillMsg_ChangeLoggingState(
+      web_contents()->GetRenderViewHost()->GetRoutingID(),
+      can_use_log_router_));
+}
+
 void ChromePasswordManagerClient::CommitFillPasswordForm(
     autofill::PasswordFormFillData* data) {
   driver_.FillPasswordForm(*data);
 }
 
 bool ChromePasswordManagerClient::IsTheHotNewBubbleUIEnabled() {
 #if !defined(USE_AURA)
   return false;
 #endif
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   if (command_line->HasSwitch(switches::kDisableSavePasswordBubble))
     return false;
 
   if (command_line->HasSwitch(switches::kEnableSavePasswordBubble))
     return true;
 
   std::string group_name =
       base::FieldTrialList::FindFullName("PasswordManagerUI");
 
   // The bubble should be the default case that runs on the bots.
   return group_name != "Infobar";
 }