Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 336743002: Invalidate Select Action bar after new input type is updated (Closed)

Created:
6 years, 6 months ago by raghu
Modified:
6 years, 6 months ago
Reviewers:
cjhopman, jdduke (slow)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Invalidate Select Action bar after new input type is updated Since Select Action bar is invalidated before the new type is updated, it shows Cut and Copy option even for password fields. hence invalidate the action bar after the input type gets updated BUG=384226 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277487

Patch Set 1 #

Patch Set 2 : Adding myself to AUTHORS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
raghu
PTAL
6 years, 6 months ago (2014-06-13 06:53:40 UTC) #1
raghu
Adding cjhopman as well for the review
6 years, 6 months ago (2014-06-13 07:16:14 UTC) #2
jdduke (slow)
On 2014/06/13 07:16:14, rvg wrote: > Adding cjhopman as well for the review Looks pretty ...
6 years, 6 months ago (2014-06-13 15:10:50 UTC) #3
cjhopman
lgtm
6 years, 6 months ago (2014-06-13 16:59:48 UTC) #4
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-14 04:18:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/336743002/20001
6 years, 6 months ago (2014-06-14 04:18:58 UTC) #6
raghu
PTAL
6 years, 6 months ago (2014-06-14 04:38:15 UTC) #7
raghu
The CQ bit was unchecked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-14 04:39:11 UTC) #8
raghu
On 2014/06/13 15:10:50, jdduke wrote: > On 2014/06/13 07:16:14, rvg wrote: > > Adding cjhopman ...
6 years, 6 months ago (2014-06-14 11:02:39 UTC) #9
raghu
On 2014/06/13 16:59:48, cjhopman wrote: > lgtm thanks
6 years, 6 months ago (2014-06-14 11:03:53 UTC) #10
raghu
Hi jdduke, Can you please review my changes. Thanks rvg
6 years, 6 months ago (2014-06-16 05:14:53 UTC) #11
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-16 09:34:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/336743002/20001
6 years, 6 months ago (2014-06-16 09:34:59 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-16 09:43:08 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/73856)
6 years, 6 months ago (2014-06-16 09:43:09 UTC) #15
jdduke (slow)
On 2014/06/16 09:43:09, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 6 months ago (2014-06-16 17:50:11 UTC) #16
raghu
The CQ bit was checked by r.ghatage@samsung.com
6 years, 6 months ago (2014-06-16 17:55:05 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.ghatage@samsung.com/336743002/20001
6 years, 6 months ago (2014-06-16 17:56:21 UTC) #18
commit-bot: I haz the power
6 years, 6 months ago (2014-06-16 18:04:48 UTC) #19
Message was sent while issue was closed.
Change committed as 277487

Powered by Google App Engine
This is Rietveld 408576698