Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336713002: Alert chrome-labs-tech-ticket when new offline device detected. (Closed)

Created:
6 years, 6 months ago by zty
Modified:
6 years, 6 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Alert chrome-labs-tech-ticket when new offline device detected. BUG=384139 R=navabi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277191

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -10 lines) Patch
M build/android/buildbot/bb_device_status_check.py View 3 chunks +31 lines, -10 lines 1 comment Download

Messages

Total messages: 12 (0 generated)
zty1
Please take a look. Thanks.
6 years, 6 months ago (2014-06-13 00:23:35 UTC) #1
friedman1
lgtm Did you test this with your email address? https://codereview.chromium.org/336713002/diff/1/build/android/buildbot/bb_device_status_check.py File build/android/buildbot/bb_device_status_check.py (right): https://codereview.chromium.org/336713002/diff/1/build/android/buildbot/bb_device_status_check.py#newcode144 build/android/buildbot/bb_device_status_check.py:144: ...
6 years, 6 months ago (2014-06-13 00:31:56 UTC) #2
zty1
I did. How do I verify tickets are being created? I'm sure I've spammed chrome-tech-lab ...
6 years, 6 months ago (2014-06-13 00:33:12 UTC) #3
zty1
The CQ bit was checked by zty@google.com
6 years, 6 months ago (2014-06-13 00:42:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/336713002/1
6 years, 6 months ago (2014-06-13 00:43:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-13 00:43:34 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-13 00:43:35 UTC) #7
navabi
lgtm Thanks Tianyin.
6 years, 6 months ago (2014-06-13 21:42:38 UTC) #8
navabi1
lgtm
6 years, 6 months ago (2014-06-13 21:42:56 UTC) #9
zty1
The CQ bit was checked by zty@google.com
6 years, 6 months ago (2014-06-13 22:15:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zty@chromium.org/336713002/1
6 years, 6 months ago (2014-06-13 22:16:46 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 07:28:17 UTC) #12
Message was sent while issue was closed. 
Change committed as 277191

Powered by Google App Engine
This is Rietveld 408576698