Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2226)

Unified Diff: Source/wtf/ListHashSet.h

Issue 336693007: Oilpan: remove invalid asserts from ListHashSet tracing. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/wtf/ListHashSet.h
diff --git a/Source/wtf/ListHashSet.h b/Source/wtf/ListHashSet.h
index 8b0f5922b94f38d2a7221ddc5f59c799892925e0..7e26077e8d347f77dc5e0ee297538f7a5044f0b1 100644
--- a/Source/wtf/ListHashSet.h
+++ b/Source/wtf/ListHashSet.h
@@ -998,13 +998,9 @@ namespace WTF {
{
COMPILE_ASSERT(HashTraits<T>::weakHandlingFlag == NoWeakHandlingInCollections, ListHashSetDoesNotSupportWeakness);
// This marks all the nodes and their contents live that can be
- // accessed through the HashTable.
+ // accessed through the HashTable. That includes m_head and m_tail
+ // so we do not have to explicitly trace them here.
m_impl.trace(visitor);
- // Due to the order in which entries are added to the hash table vs.
- // when they are put in the linked list we have now marked all the
- // nodes live.
- ASSERT(!m_head || Allocator::isAlive(visitor, m_head));
- ASSERT(!m_tail || Allocator::isAlive(visitor, m_tail));
}
} // namespace WTF
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698