LayoutTests/css3/images/pixelated-canvas.html - Issue 336693005: Add image-rendering: pixelated.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/images/pixelated-canvas.html

Issue 336693005: Add image-rendering: pixelated. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Address comments. Update test. Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <style>

	3 canvas {

	4 display: block;

	5 position: fixed;
	pdr. 2014/06/13 03:59:23 There are a lot of unnecessary values here. I thin There are a lot of unnecessary values here. I think you just want: width: 100px; height: 100px; image-rendering: pixelated; jackhou 2014/06/13 04:27:32 Done. Show quoted text On 2014/06/13 03:59:23, pdr wrote: > There are a lot of unnecessary values here. I think you just want: > width: 100px; > height: 100px; > image-rendering: pixelated; Done.
	6 left: 0px;

	7 top: 0px;

	8 right: 0px;

	9 bottom: 0px;

	10 border: none;

	11 width: 100px;

	12 height: 100px;

	13 margin: 0px;

	14 padding: 0px;

	15 image-rendering: pixelated;

	16 }

	17 </style>

	18 <body>

	19 <!-- The resulting image should be 100x100, consisting of 4 50x50 blocks of solid color, with no blurring of edges -->

	20 <canvas width="2" height="2"></canvas>

	21 </body>

	22 <script>

	23 if (window.layoutTestController)
	pdr. 2014/06/13 03:59:23 I haven't seen this since pre-fork Webkit :) Can y I haven't seen this since pre-fork Webkit :) Can you switch this to testRunner instead of layoutTestController? I'm not sure why you want dumpAsText though. Don't you just want the image result? jackhou 2014/06/13 04:27:31 Yeah, I patched these from a 2 year old CL without Show quoted text On 2014/06/13 03:59:23, pdr wrote: > I haven't seen this since pre-fork Webkit :) Can you switch this to testRunner > instead of layoutTestController? > > I'm not sure why you want dumpAsText though. Don't you just want the image > result? Yeah, I patched these from a 2 year old CL without really understanding them. I think the dumpAsText can be removed, the test works without them.
	24 layoutTestController.dumpAsText(true);

	25

	26 var canvas;
	pdr. 2014/06/13 03:59:23 Nit: indentation. Nit: indentation. jackhou 2014/06/13 04:27:31 Done. Show quoted text On 2014/06/13 03:59:23, pdr wrote: > Nit: indentation. Done.
	27 var imageHandle;

	28 canvas = document.getElementsByTagName("canvas")[0].getContext("2d");

	29 canvas.width = 2;

	30 canvas.height = 2;

	31 imageHandle = canvas.createImageData(2, 2);

	32

	33 var index = 0;

	34 var length = imageHandle.data.length;

	35

	36 imageHandle.data[index++] = 255;

	37 imageHandle.data[index++] = 0;

	38 imageHandle.data[index++] = 0;

	39 imageHandle.data[index++] = 255;

	40

	41 imageHandle.data[index++] = 0;

	42 imageHandle.data[index++] = 255;

	43 imageHandle.data[index++] = 0;

	44 imageHandle.data[index++] = 255;

	45

	46 imageHandle.data[index++] = 0;

	47 imageHandle.data[index++] = 0;

	48 imageHandle.data[index++] = 255;

	49 imageHandle.data[index++] = 255;

	50

	51 imageHandle.data[index++] = 0;

	52 imageHandle.data[index++] = 0;

	53 imageHandle.data[index++] = 0;

	54 imageHandle.data[index++] = 255;

	55

	56 canvas.putImageData(imageHandle, 0, 0);
	pdr. 2014/06/13 03:59:23 nit: indentation. nit: indentation. jackhou 2014/06/13 04:27:31 Done. Show quoted text On 2014/06/13 03:59:23, pdr wrote: > nit: indentation. Done.
	57 </script>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/css3/images/pixelated-canvas-expected.png » ('j') | LayoutTests/css3/images/pixelated-image.html » ('J')