Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: Source/core/frame/DeviceSensorEventDispatcher.cpp

Issue 336693004: Deduplicate DeviceEvent* classes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: oops - fix grammar in test expectation as well Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/DeviceSensorEventDispatcher.cpp
diff --git a/Source/core/frame/DeviceSensorEventDispatcher.cpp b/Source/core/frame/DeviceSensorEventDispatcher.cpp
deleted file mode 100644
index a992f0aa2e5246d1cce865668bee49ce393a8975..0000000000000000000000000000000000000000
--- a/Source/core/frame/DeviceSensorEventDispatcher.cpp
+++ /dev/null
@@ -1,95 +0,0 @@
-/*
- * Copyright (C) 2013 Google Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are
- * met:
- *
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above
- * copyright notice, this list of conditions and the following disclaimer
- * in the documentation and/or other materials provided with the
- * distribution.
- * * Neither the name of Google Inc. nor the names of its
- * contributors may be used to endorse or promote products derived from
- * this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
- * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
- * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
- * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
- * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
- * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
- * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
- * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
- * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
- * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "config.h"
-#include "core/frame/DeviceSensorEventDispatcher.h"
-
-namespace WebCore {
-
-DeviceSensorEventDispatcher::DeviceSensorEventDispatcher()
- : m_needsPurge(false)
- , m_isDispatching(false)
-{
-}
-
-DeviceSensorEventDispatcher::~DeviceSensorEventDispatcher()
-{
-}
-
-void DeviceSensorEventDispatcher::addController(DeviceSensorEventController* controller)
-{
- bool wasEmpty = m_controllers.isEmpty();
- if (!m_controllers.contains(controller))
- m_controllers.append(controller);
- if (wasEmpty)
- startListening();
-}
-
-void DeviceSensorEventDispatcher::removeController(DeviceSensorEventController* controller)
-{
- // Do not actually remove the controller from the vector, instead zero them out.
- // The zeros are removed in these two cases:
- // 1. either immediately if we are not dispatching any events,
- // 2. or after events to all controllers have dispatched
- // (see e.g. DeviceOrientationDispatcher::didChangeDeviceOrientation).
- // This is to correctly handle the re-entrancy case when a controller is destroyed
- // while the events are still being dispatched.
- size_t index = m_controllers.find(controller);
- if (index == kNotFound)
- return;
-
- m_controllers[index] = 0;
- m_needsPurge = true;
-
- if (!m_isDispatching)
- purgeControllers();
-}
-
-void DeviceSensorEventDispatcher::purgeControllers()
-{
- ASSERT(m_needsPurge);
-
- size_t i = 0;
- while (i < m_controllers.size()) {
- if (!m_controllers[i]) {
- m_controllers[i] = m_controllers.last();
- m_controllers.removeLast();
- } else {
- ++i;
- }
- }
-
- m_needsPurge = false;
-
- if (m_controllers.isEmpty())
- stopListening();
-}
-
-} // namespace WebCore
« no previous file with comments | « Source/core/frame/DeviceSensorEventDispatcher.h ('k') | Source/modules/device_light/DeviceLightDispatcher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698