LayoutTests/gamepad/multiple-event-listeners.html - Issue 336693004: Deduplicate DeviceEvent* classes

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/gamepad/multiple-event-listeners.html

Issue 336693004: Deduplicate DeviceEvent* classes (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: derive from *Base Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <body>

	4 <script src="../resources/js-test.js"></script>

	5 <script>

	6 description("Test that when there are multiple gamepad event listeners and one i s getting removed the others still recieves events.");

	7 window.jsTestIsAsync = true;

	8

	9 if (!window.gamepadController) {

	10 debug("This test cannot work without gamepadController.");

	11 }

	12

	13 var listenerToRemove = window.addEventListener('gamepadconnected', function() {} );

	14 window.addEventListener('gamepadconnected', function() {

	15 testPassed("gamepadconnected event recieved");

	16 finishJSTest();

	17 });

	18 window.removeEventListener('gamepadconnected', listenerToRemove);
	timvolodine 2014/06/16 13:05:17 why is this needed? adding and removing an empty l why is this needed? adding and removing an empty listener? kbalazs 2014/06/16 17:01:47 This tests that we still honor the other listeners Show quoted text On 2014/06/16 13:05:17, timvolodine wrote: > why is this needed? adding and removing an empty listener? This tests that we still honor the other listeners if one is removed. Look at the change in NavigatorGamepad::didRemoveEventListener, before the patch we did not check if there is other listeners before setting m_hasEventListener to false.
	19

	20 setTimeout(function() {

	21 testFailed("gamepadconnected event should have been recieved.");

	22 finishJSTest();

	23 }, 50);

	24

	25 if (gamepadController) {

	26 gamepadController.connect(0);

	27 gamepadController.dispatchConnected(0);

	28 }

	29

	30 </script>

	31 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/gamepad/multiple-event-listeners-expected.txt » ('j') | Source/modules/gamepad/GamepadDispatcher.h » ('J')