Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 336653004: Decrease binary size by 43 KB by removing V8XXX::domTemplate (Closed)

Created:
6 years, 6 months ago by haraken
Modified:
6 years, 6 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Decrease binary size by 43 KB by removing V8XXX::domTemplate This CL moves off the contents of V8XXX::domTemplate from V8XXX.cpp to V8DOMConfiguration.cpp. By doing this, we can decrease the binary size by 43 KB. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176096

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -250 lines) Patch
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8SVGTestInterface.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface2.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface3.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDocument.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceGarbageCollected.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNode.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceWillBeGarbageCollected.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperations.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/bindings/v8/V8DOMConfiguration.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/v8/V8DOMConfiguration.cpp View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
haraken
PTAL
6 years, 6 months ago (2014-06-13 05:52:01 UTC) #1
Nils Barth (inactive)
LGTM FWIW; always a fan of moving code from generated bindings to static bindings if ...
6 years, 6 months ago (2014-06-13 05:57:25 UTC) #2
haraken
The CQ bit was checked by haraken@chromium.org
6 years, 6 months ago (2014-06-13 05:58:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/336653004/1
6 years, 6 months ago (2014-06-13 05:58:42 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-13 07:01:26 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 08:31:41 UTC) #6
Message was sent while issue was closed.
Change committed as 176096

Powered by Google App Engine
This is Rietveld 408576698