Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336653003: Fix crash due to null frame() pointer on Document. (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, blink-reviews-html_chromium.org, dglazkov+blink
Project:
blink
Visibility:
Public.

Description

Fix crash due to null frame() pointer on Document. BUG=383985 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176095

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
chrishtr
I can't reproduce the crash unfortunately. But the crash stack is below FrameLoader::detachFromParent, which clearly ...
6 years, 6 months ago (2014-06-12 20:57:03 UTC) #1
abarth-chromium
LGTM, but it's sad not to have a test.
6 years, 6 months ago (2014-06-13 05:36:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/336653003/1
6 years, 6 months ago (2014-06-13 05:36:38 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 08:30:58 UTC) #4
Message was sent while issue was closed. 
Change committed as 176095

Powered by Google App Engine
This is Rietveld 408576698