Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 336653002: Revert: Per navigation sticky media permissions. (Closed)

Created:
6 years, 6 months ago by tommi (sloooow) - chröme
Modified:
6 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, wjia+watch_chromium.org, mcasas+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert: Per navigation sticky media permissions. This CL re-enables the same behavior for getUserMedia prompts as it was in M35. The reason for this is because there was a change of hearts at the standards level about this. More information in the issue. BUG=269719 COLLABORATOR=xians Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276974

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -161 lines) Patch
M chrome/browser/media/chrome_media_stream_infobar_browsertest.cc View 2 chunks +1 line, -50 lines 0 comments Download
M chrome/browser/media/media_stream_devices_controller.cc View 6 chunks +0 lines, -111 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tommi (sloooow) - chröme
6 years, 6 months ago (2014-06-12 20:22:42 UTC) #1
tommi (sloooow) - chröme
On 2014/06/12 20:22:42, tommi (OOO June 13-23) wrote: Shijing - can you land this tomorrow ...
6 years, 6 months ago (2014-06-12 21:26:43 UTC) #2
no longer working on chromium
On 2014/06/12 21:26:43, tommi (OOO June 13-23) wrote: > On 2014/06/12 20:22:42, tommi (OOO June ...
6 years, 6 months ago (2014-06-13 07:34:49 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 6 months ago (2014-06-13 07:34:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tommi@chromium.org/336653002/1
6 years, 6 months ago (2014-06-13 07:36:12 UTC) #5
commit-bot: I haz the power
Change committed as 276974
6 years, 6 months ago (2014-06-13 08:39:02 UTC) #6
henrika (OOO until Aug 14)
6 years, 6 months ago (2014-06-16 07:40:03 UTC) #7
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/338753002/ by henrika@chromium.org.

The reason for reverting is: THis CL breaks several WebRTC bots. See e.g.
http://chromegw.corp.google.com/i/internal.chromium.webrtc/builders/Win7%20Te....

[32/32]
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1
(TIMED OUT)
2 tests timed out:
   
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/0
   
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.TestAcquiringAndReacquiringWebcam/1.

Powered by Google App Engine
This is Rietveld 408576698