Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 336633003: GN: Add disabled-by-default heap asm rules (Closed)

Created:
6 years, 6 months ago by jamesr
Modified:
6 years, 6 months ago
Reviewers:
brettw
CC:
blink-reviews
Visibility:
Public.

Description

GN: Add disabled-by-default heap asm rules Depends on the yasm stuff landing and sticking. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176153

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -10 lines) Patch
M Source/platform/BUILD.gn View 1 5 chunks +58 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jamesr
6 years, 6 months ago (2014-06-12 19:14:07 UTC) #1
brettw
lgtm
6 years, 6 months ago (2014-06-12 19:16:44 UTC) #2
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 6 months ago (2014-06-14 04:31:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/336633003/20001
6 years, 6 months ago (2014-06-14 04:32:32 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-14 05:35:32 UTC) #5
Message was sent while issue was closed.
Change committed as 176153

Powered by Google App Engine
This is Rietveld 408576698