Issue 336633002: Add libflac and speex to the GN build.

Issue 336633002: Add libflac and speex to the GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
tfarina, scottmg

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add libflac and speex to the GN build. R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276773

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+168 lines, -0 lines)			Patch
M	BUILD.gn	View	2 chunks	+2 lines, -0 lines	2 comments	Download
A	tools/gn/secondary/third_party/flac/BUILD.gn	View	1 chunk	+76 lines, -0 lines	1 comment	Download
A	tools/gn/secondary/third_party/speex/BUILD.gn	View	1 chunk	+90 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

scottmg

lgtm https://codereview.chromium.org/336633002/diff/1/tools/gn/secondary/third_party/flac/BUILD.gn File tools/gn/secondary/third_party/flac/BUILD.gn (right): https://codereview.chromium.org/336633002/diff/1/tools/gn/secondary/third_party/flac/BUILD.gn#newcode6 tools/gn/secondary/third_party/flac/BUILD.gn:6: defines = [ "FLAC__NO_DLL" ] wth is with ...

6 years, 6 months ago (2014-06-12 18:21:50 UTC) #2

brettw

Committed patchset #1 manually as r276773 (presubmit successful).

6 years, 6 months ago (2014-06-12 19:37:34 UTC) #3

tfarina

https://codereview.chromium.org/336633002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/336633002/diff/1/BUILD.gn#newcode81 BUILD.gn:81: "//third_party/speex", I said on my Snippets I was going ...

6 years, 6 months ago (2014-06-13 19:11:49 UTC) #4

tfarina

https://codereview.chromium.org/336633002/diff/1/tools/gn/secondary/third_party/speex/BUILD.gn File tools/gn/secondary/third_party/speex/BUILD.gn (right): https://codereview.chromium.org/336633002/diff/1/tools/gn/secondary/third_party/speex/BUILD.gn#newcode10 tools/gn/secondary/third_party/speex/BUILD.gn:10: static_library("speex") { HUM? Why you added this? I added ...

6 years, 6 months ago (2014-06-13 19:12:58 UTC) #5

brettw

6 years, 6 months ago (2014-06-13 23:36:25 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/336633002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/336633002/diff/1/BUILD.gn#newcode81
BUILD.gn:81: "//third_party/speex",
Whoops sorry! I was just blindly going through deps I needed for content. Looks
like we just need to roll deps on speex and then your file will start working
and we can delete mine.

Expand Messages | Collapse Messages