Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 336603005: Revert of [Mac] Use a native MessagePump instead of a MessagePumpDefault (Closed)

Created:
6 years, 6 months ago by jeremy
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org, sadrul, tonyg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of [Mac] Use a native MessagePump instead of a MessagePumpDefault (https://codereview.chromium.org/331513002/) Reason for revert: Broke Jingle unit tests on the bots. Original issue's description: > [Mac] Use a native MessagePump instead of a MessagePumpDefault > > Many message loops in Chrome are backed by MessagePumpDefault which uses a WaitableEvent object to sleep, this is ultimately implemented as a pthread condition variable on POSIX. > > In order to support timer coalescing in MessageLoops we need to sleep using a primitive which supports timer coalescing at the OS level (support for timer coalescing goes down into the kernel on Android/Linux/OSX/Win). The current change achieves this and should provide a way to gauge the effect of timer coalescing. > > An alternate approach to this patch would be to implement MessagePumpDefault using a primitive which supports timer coalescing. > > Local performance tests didn't uncover any regressions from this change. > > BUG=356804 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276808 TBR=darin@chromium.org,mark@chromium.org NOTREECHECKS=true NOTRY=true BUG=356804 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276846

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M base/message_loop/message_loop.cc View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jeremy
Created Revert of [Mac] Use a native MessagePump instead of a MessagePumpDefault
6 years, 6 months ago (2014-06-12 23:16:55 UTC) #1
Mark Mentovai
LGTM
6 years, 6 months ago (2014-06-12 23:19:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/336603005/1
6 years, 6 months ago (2014-06-12 23:19:31 UTC) #3
commit-bot: I haz the power
Change committed as 276846
6 years, 6 months ago (2014-06-12 23:22:50 UTC) #4
Lei Zhang
base_unittests on Mac Valgrind wasn't happy either: http://goo.gl/wPBSgT
6 years, 6 months ago (2014-06-14 00:48:31 UTC) #5
jeremy
6 years, 6 months ago (2014-06-17 13:22:30 UTC) #6
Message was sent while issue was closed.
thestig: Thanks! I've filed crbug.com/385604 to track when I reland the patch.

Powered by Google App Engine
This is Rietveld 408576698