 Chromium Code Reviews
 Chromium Code Reviews Issue 
            336603005:
    Revert of [Mac] Use a native MessagePump instead of a MessagePumpDefault  (Closed)
    
  
    Issue 
            336603005:
    Revert of [Mac] Use a native MessagePump instead of a MessagePumpDefault  (Closed) 
  | DescriptionRevert of [Mac] Use a native MessagePump instead of a MessagePumpDefault (https://codereview.chromium.org/331513002/)
Reason for revert:
Broke Jingle unit tests on the bots.
Original issue's description:
> [Mac] Use a native MessagePump instead of a MessagePumpDefault
> 
> Many message loops in Chrome are backed by MessagePumpDefault which uses a WaitableEvent object to sleep, this is ultimately implemented as a pthread condition variable on POSIX.
> 
> In order to support timer coalescing in MessageLoops we need to sleep using a primitive which supports timer coalescing at the OS level (support for timer coalescing goes down into the kernel on Android/Linux/OSX/Win).  The current change achieves this and should provide a way to gauge the effect of timer coalescing.
> 
> An alternate approach to this patch would be to implement MessagePumpDefault using a primitive which supports timer coalescing.
> 
> Local performance tests didn't uncover any regressions from this change.
> 
> BUG=356804
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276808
TBR=darin@chromium.org,mark@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=356804
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276846
   Patch Set 1 #
      Created: 6 years, 6 months ago
     
      
        (Patch set is too large to download)
      
     
 Messages
    Total messages: 6 (0 generated)
     | |||||||||||||||||||