Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 336603004: Change complex-text-missing-glyph-fallback to have fixed line height (Closed)

Created:
6 years, 6 months ago by eae
Modified:
6 years, 6 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Change complex-text-missing-glyph-fallback to have fixed line height Change the fast/text/international/complex-text-missing-glyph-fallback .html test to have a fixed line height to account for differences between fonts. BUG=378610 TBR=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176053

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/text/international/complex-text-missing-glyph-fallback.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/text/international/complex-text-missing-glyph-fallback-expected.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eae
The CQ bit was checked by eae@chromium.org
6 years, 6 months ago (2014-06-12 18:41:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/336603004/1
6 years, 6 months ago (2014-06-12 18:42:10 UTC) #2
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_dbg on tryserver.blink ...
6 years, 6 months ago (2014-06-12 19:28:07 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 21:41:13 UTC) #4
Message was sent while issue was closed.
Change committed as 176053

Powered by Google App Engine
This is Rietveld 408576698