Issue 336603002: Add CHECK for rare ChromeLauncherController crash

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336603002: Add CHECK for rare ChromeLauncherController crash (Closed)

Created:
6 years, 6 months ago by James Cook

Modified:
6 years, 6 months ago

Reviewers:
Elliot Glaysher, Mr4D (OOO till 08-26)

CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org, Dmitry Polukhin

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add CHECK in ProfileManager::GetActiveUserProfile() for rare crash There's a rare crash in ChromeLauncherController that looks like a user is switching into Ash with no profile and a read-only profile directory. Add a CHECK to figure out how common this problem is. BUG=383019 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276868

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	chrome/browser/profiles/profile_manager.cc	View		1 chunk	+10 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/336603002/1

6 years, 6 months ago (2014-06-12 19:25:41 UTC) #6

Message was sent while issue was closed.

Change committed as 276868

Expand Messages | Collapse Messages