Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: WebCore/editing/DeleteButton.cpp

Issue 3366025: Merge 67246 - 2010-09-109 Peter Kasting <pkasting@google.com>... (Closed) Base URL: http://svn.webkit.org/repository/webkit/branches/chromium/517/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « WebCore/ChangeLog ('k') | WebCore/html/HTMLAnchorElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: WebCore/editing/DeleteButton.cpp
===================================================================
--- WebCore/editing/DeleteButton.cpp (revision 67261)
+++ WebCore/editing/DeleteButton.cpp (working copy)
@@ -50,14 +50,10 @@
void DeleteButton::defaultEventHandler(Event* event)
{
- // FIXME: Is it really import to check the type of the event?
- // Seems OK to respond to any event named click even if it does not have the correct type.
- if (event->isMouseEvent()) {
- if (event->type() == eventNames().clickEvent) {
- document()->frame()->editor()->deleteButtonController()->deleteTarget();
- event->setDefaultHandled();
- // FIXME: Shouldn't we return here instead of falling through?
- }
+ if (event->type() == eventNames().clickEvent) {
+ document()->frame()->editor()->deleteButtonController()->deleteTarget();
+ event->setDefaultHandled();
+ return;
}
HTMLImageElement::defaultEventHandler(event);
« no previous file with comments | « WebCore/ChangeLog ('k') | WebCore/html/HTMLAnchorElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698