chrome/service/cloud_print/cloud_print_proxy_backend.cc - Issue 3366011: base: Move SplitStringDontTrim functions from string_util.h to string_split.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_proxy_backend.cc

Issue 3366011: base: Move SplitStringDontTrim functions from string_util.h to string_split.h (Closed) Base URL: git://git.chromium.org/chromium.git

Patch Set: remove dchecks Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc ('k') | net/websockets/websocket_handshake_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_proxy_backend.cc

diff --git a/chrome/service/cloud_print/cloud_print_proxy_backend.cc b/chrome/service/cloud_print/cloud_print_proxy_backend.cc

index 993605f16bf9143fedf5ff6145a87ad974836d1b..4505a7df3cbbd1116e7e45c54fdfb04dcbbec935 100644

--- a/chrome/service/cloud_print/cloud_print_proxy_backend.cc

+++ b/chrome/service/cloud_print/cloud_print_proxy_backend.cc

@@ -7,6 +7,7 @@

#include "base/file_util.h"

#include "base/md5.h"

#include "base/rand_util.h"

+#include "base/string_split.h"

#include "base/string_util.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

@@ -630,7 +631,7 @@ void CloudPrintProxyBackend::Core::InitJobHandlerForPrinter(

tags_list->GetString(index, &tag);

if (StartsWithASCII(tag, kTagsHashTagName, false)) {

std::vector<std::string> tag_parts;

- SplitStringDontTrim(tag, '=', &tag_parts);

+ base::SplitStringDontTrim(tag, '=', &tag_parts);

DCHECK(tag_parts.size() == 2);

if (tag_parts.size() == 2) {

printer_info_cloud.tags_hash = tag_parts[1];

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc ('k') | net/websockets/websocket_handshake_unittest.cc » ('j') | no next file with comments »