Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2948)

Unified Diff: base/string_util.cc

Issue 3366011: base: Move SplitStringDontTrim functions from string_util.h to string_split.h (Closed) Base URL: git://git.chromium.org/chromium.git
Patch Set: remove dchecks Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/string_util.h ('k') | base/string_util_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/string_util.cc
diff --git a/base/string_util.cc b/base/string_util.cc
index 68f3d914ee6f3794055fbdb96bbf35ccc94d7c24..ba9108bb8cbb2035d4db43fef87d476620914ccc 100644
--- a/base/string_util.cc
+++ b/base/string_util.cc
@@ -757,6 +757,8 @@ void ReplaceSubstringsAfterOffset(std::string* str,
true); // replace all instances
}
+// TODO(tfarina): Remove this when finish moving SplitString functions to
+// string_split.[cc/h].
template<typename STR>
static void SplitStringT(const STR& str,
const typename STR::value_type s,
@@ -801,26 +803,6 @@ void SplitString(const std::string& str,
SplitStringT(str, s, true, r);
}
-void SplitStringDontTrim(const std::wstring& str,
- wchar_t s,
- std::vector<std::wstring>* r) {
- SplitStringT(str, s, false, r);
-}
-
-#if !defined(WCHAR_T_IS_UTF16)
-void SplitStringDontTrim(const string16& str,
- char16 s,
- std::vector<string16>* r) {
- SplitStringT(str, s, false, r);
-}
-#endif
-
-void SplitStringDontTrim(const std::string& str,
- char s,
- std::vector<std::string>* r) {
- SplitStringT(str, s, false, r);
-}
-
template<typename STR>
static size_t TokenizeT(const STR& str,
const STR& delimiters,
« no previous file with comments | « base/string_util.h ('k') | base/string_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698