Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336583002: Disable context menu for constrained inline signin (Closed)

Created:
6 years, 6 months ago by guohui
Modified:
6 years, 6 months ago
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Disable context menu for constrained inline signin BUG=380134 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276901

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M chrome/browser/ui/webui/signin/inline_login_handler_impl.h View 2 chunks +7 lines, -1 line 2 comments Download
M chrome/browser/ui/webui/signin/inline_login_handler_impl.cc View 1 chunk +17 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
guohui
Hey, could you please review the CL? Thanks, Hui
6 years, 6 months ago (2014-06-12 17:19:22 UTC) #1
xiyuan
https://codereview.chromium.org/336583002/diff/60001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h File chrome/browser/ui/webui/signin/inline_login_handler_impl.h (right): https://codereview.chromium.org/336583002/diff/60001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h#newcode44 chrome/browser/ui/webui/signin/inline_login_handler_impl.h:44: virtual bool HandleContextMenu( Move this to InlineLoginHandler to fix ...
6 years, 6 months ago (2014-06-12 18:02:04 UTC) #2
guohui
https://codereview.chromium.org/336583002/diff/60001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h File chrome/browser/ui/webui/signin/inline_login_handler_impl.h (right): https://codereview.chromium.org/336583002/diff/60001/chrome/browser/ui/webui/signin/inline_login_handler_impl.h#newcode44 chrome/browser/ui/webui/signin/inline_login_handler_impl.h:44: virtual bool HandleContextMenu( On 2014/06/12 18:02:04, xiyuan wrote: > ...
6 years, 6 months ago (2014-06-12 20:15:38 UTC) #3
xiyuan
Sorry that I asked for the wrong thing. I forgot that ChromeOS uses WebDialog and ...
6 years, 6 months ago (2014-06-12 20:25:07 UTC) #4
guohui
On 2014/06/12 20:25:07, xiyuan wrote: > Sorry that I asked for the wrong thing. I ...
6 years, 6 months ago (2014-06-12 20:26:11 UTC) #5
xiyuan
LGTM! Thank you and sorry for the trouble. :p
6 years, 6 months ago (2014-06-12 20:28:52 UTC) #6
guohui
On 2014/06/12 20:28:52, xiyuan wrote: > LGTM! > > Thank you and sorry for the ...
6 years, 6 months ago (2014-06-12 20:29:15 UTC) #7
guohui
The CQ bit was checked by guohui@chromium.org
6 years, 6 months ago (2014-06-12 20:29:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/guohui@chromium.org/336583002/60001
6 years, 6 months ago (2014-06-12 20:32:34 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 02:50:00 UTC) #10
Message was sent while issue was closed. 
Change committed as 276901

Powered by Google App Engine
This is Rietveld 408576698