NaCl SDK doc: Recover sandbox internal doc for x86-64

NaCl SDK doc: Recover sandbox internal doc for x86-64

BUG=None
TEST=N/A

[hamaji, 2014-06-12 16:48:59]

I recovered this from http://archive.today/XgOy5

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:216: ..
raw:: html
Let me copy the html in the original document...

[Sam Clegg, 2014-06-12 17:36:16]

Thanks for doing this!  A few drive-by nits..

Did you forget to 'git add' the new html page?

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:190:
operand prefix ensures that:
nit: It looks like your paragraphs are wrapped at 80 columns.   Are you using
some smaller value when you reflow your paras?

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:195:
%nacl:(,%r11),  the notation %eXX is referring to %r11d)
Maybe use fixed width for inline asm and register names? e.g. ``%eXX``

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:216: ..
raw:: html
On 2014/06/12 16:48:59, hamaji wrote:
> Let me copy the html in the original document...

Would be nice not use html if possible.  Or at least at a TODO to convert this
to a rst table.

[hamaji, 2014-06-12 18:03:53]

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:190:
operand prefix ensures that:
On 2014/06/12 17:36:16, Sam Clegg wrote:
> nit: It looks like your paragraphs are wrapped at 80 columns.   Are you using
> some smaller value when you reflow your paras?

I'm using the default value of emacs, which seems to be 70. Do you think I
should fix this? I think this setting is not consistent and this does not matter
for RST anyway. For example, I think arm-32-bit-sandbox.rst was wrapped at 72,
and I can see other files use different values.

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:195:
%nacl:(,%r11),  the notation %eXX is referring to %r11d)
On 2014/06/12 17:36:16, Sam Clegg wrote:
> Maybe use fixed width for inline asm and register names? e.g. ``%eXX``

Done.

https://codereview.chromium.org/336563003/diff/1/native_client_sdk/src/doc/re...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:216: ..
raw:: html
On 2014/06/12 17:36:15, Sam Clegg wrote:
> On 2014/06/12 16:48:59, hamaji wrote:
> > Let me copy the html in the original document...
> 
> Would be nice not use html if possible.  Or at least at a TODO to convert this
> to a rst table.

Let me leave this with a TODO.

[Sam Clegg, 2014-06-12 19:28:12]

I still don't see the new html file..

Otherwise lgtm, although I didn't go through and make sure the content exactly
matched the original page.

[JF, 2014-06-12 20:00:47]

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/reference/sandbox_internals/index.rst (right):

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/index.rst:32: design has
changed slightly since then.
The link to the research paper is already in the document you ported, so this
section should only have the <x86-64-sandbox> link that you added.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:5:
================================
We're missing the HTML file corresponding to the rst file.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:19:
<http://static.googleusercontent.com/media/research.google.com/ja//pubs/archiv....
Make it https, the server supports it.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:28:
src, dst.
Code-quote code: ``mov src, dst``

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:107: *
``pusha``/``popa`` (not dangerous but not needed for gcc)
s/gcc/GCC/

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:122:
definition) producer instruction and it's corresponding restricted
s/it's/its/

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:128:
``CALL``/``JMP`` x, use nacljmp and naclcall (see below for
Code-quote ``nacljmp`` and ``naclcall``.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:144:
[rep] stos (other string instructions can be used here)
Make the parenthesized section a comment? Same in other code locations below.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:157:
mov ..., %eXX (any 32-bit register can be used here; the first operand is
unrestricted but often is the same register)
You should manually line-wrap the comment here, because the website's format
will make the overflow look ugly otherwise.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:159: *
Instructions capable of changing %RBP and %RSP are forbidden, except
Code-quote the register names.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:180:
popq ...(except pop %RSP, pop %RBP)
Ditto on parenthesis being comments, and line-wrap.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:217: ..
TODO(hamaji): Use rst's table instead of the raw HTML below.
Please do :)

[Junichi Uekawa, 2014-06-13 03:58:30]

drive by

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:19:
<http://static.googleusercontent.com/media/research.google.com/ja//pubs/archiv....
I think you want the URL
http://research.google.com/pubs/archive/35649.pdf

It redirects to 
http://static.googleusercontent.com/media/research.google.com/ja/us/pubs/arch...
depending on the locale of the browser settings, it seems.

[hamaji, 2014-06-13 04:08:19]

Sorry Sam, I missed your header comment. Now I have added the generated HTML.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/reference/sandbox_internals/index.rst (right):

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/index.rst:32: design has
changed slightly since then.
On 2014/06/12 20:00:46, JF wrote:
> The link to the research paper is already in the document you ported, so this
> section should only have the <x86-64-sandbox> link that you added.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:5:
================================
On 2014/06/12 20:00:47, JF wrote:
> We're missing the HTML file corresponding to the rst file.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:19:
<http://static.googleusercontent.com/media/research.google.com/ja//pubs/archiv....
On 2014/06/12 20:00:47, JF wrote:
> Make it https, the server supports it.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:19:
<http://static.googleusercontent.com/media/research.google.com/ja//pubs/archiv....
On 2014/06/13 03:58:30, uekawa wrote:
> I think you want the URL
> http://research.google.com/pubs/archive/35649.pdf
> 
> It redirects to 
>
http://static.googleusercontent.com/media/research.google.com/ja/us/pubs/arch...
> depending on the locale of the browser settings, it seems.

Done, thanks!

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:28:
src, dst.
On 2014/06/12 20:00:46, JF wrote:
> Code-quote code: ``mov src, dst``

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:107: *
``pusha``/``popa`` (not dangerous but not needed for gcc)
On 2014/06/12 20:00:47, JF wrote:
> s/gcc/GCC/

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:122:
definition) producer instruction and it's corresponding restricted
On 2014/06/12 20:00:47, JF wrote:
> s/it's/its/

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:128:
``CALL``/``JMP`` x, use nacljmp and naclcall (see below for
On 2014/06/12 20:00:47, JF wrote:
> Code-quote ``nacljmp`` and ``naclcall``.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:144:
[rep] stos (other string instructions can be used here)
On 2014/06/12 20:00:47, JF wrote:
> Make the parenthesized section a comment? Same in other code locations below.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:157:
mov ..., %eXX (any 32-bit register can be used here; the first operand is
unrestricted but often is the same register)
On 2014/06/12 20:00:47, JF wrote:
> You should manually line-wrap the comment here, because the website's format
> will make the overflow look ugly otherwise.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:159: *
Instructions capable of changing %RBP and %RSP are forbidden, except
On 2014/06/12 20:00:46, JF wrote:
> Code-quote the register names.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:180:
popq ...(except pop %RSP, pop %RBP)
On 2014/06/12 20:00:47, JF wrote:
> Ditto on parenthesis being comments, and line-wrap.

Done.

https://codereview.chromium.org/336563003/diff/20001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:217: ..
TODO(hamaji): Use rst's table instead of the raw HTML below.
On 2014/06/12 20:00:46, JF wrote:
> Please do :)

Sorry, but I don't have spare time for this now. If TODO is not acceptable for
you, I'd abandon this change for now and will resume the work.

[JF, 2014-06-13 06:56:05]

lgtm after comments.

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:144:
[rep] stos  ; (other string instructions can be used here)
Can you remove the parenthesis here.

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:158: ;
unrestricted but often is the same register)
Same.

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:173:
add %rZP, %rsp  ; (restoration of %RSP from memory, register or stack - keeps
the invariant intact)
Could you line-wrap the two lines above, and remove parens.

[hamaji, 2014-06-13 14:55:25]

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
File native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst
(right):

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:144:
[rep] stos  ; (other string instructions can be used here)
On 2014/06/13 06:56:05, JF wrote:
> Can you remove the parenthesis here.

Done.

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:158: ;
unrestricted but often is the same register)
On 2014/06/13 06:56:05, JF wrote:
> Same.

Done.

https://codereview.chromium.org/336563003/diff/60001/native_client_sdk/src/do...
native_client_sdk/src/doc/reference/sandbox_internals/x86-64-sandbox.rst:173:
add %rZP, %rsp  ; (restoration of %RSP from memory, register or stack - keeps
the invariant intact)
On 2014/06/13 06:56:05, JF wrote:
> Could you line-wrap the two lines above, and remove parens.

Done.

[hamaji, 2014-06-13 14:58:24]

The CQ bit was checked by hamaji@chromium.org

[commit-bot: I haz the power, 2014-06-13 14:59:06]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hamaji@chromium.org/336563003/80001

[commit-bot: I haz the power, 2014-06-13 15:25:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  android_chromium_gn_compile_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_chromium_gn_c...)
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  android_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/19...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  linux_chromium_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_clang_...)
  linux_chromium_gn_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_gn_rel...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
  mac_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_compile_...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16576)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/19813)

[commit-bot: I haz the power, 2014-06-13 15:27:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-13 15:27:20]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/8...)
  ios_dbg_simulator on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/bui...)
  ios_rel_device on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device/builds...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/16590)