Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp - Issue 336553003: Change Page::m_mainFrame to be a Frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

Issue 336553003: Change Page::m_mainFrame to be a Frame. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Android/Mac fixes Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/v8/PageScriptDebugServer.cpp ('K') | « Source/core/testing/Internals.cpp ('k') | Source/modules/filesystem/InspectorFrontendHostFileSystem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

diff --git a/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp b/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

index e49ad92e5365d2707927e6c3c8ee8d54e5370653..746cc9dec8d5e2dcca085e56ab6e7a1695027c4a 100644

--- a/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

+++ b/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp

@@ -41,8 +41,8 @@ DeviceOrientationInspectorAgent::DeviceOrientationInspectorAgent(Page& page)

DeviceOrientationController& DeviceOrientationInspectorAgent::controller()

{

- ASSERT(m_page.mainFrame()->document());

- return DeviceOrientationController::from(*m_page.mainFrame()->document());

+ ASSERT(toLocalFrame(m_page.mainFrame())->document());

+ return DeviceOrientationController::from(*toLocalFrame(m_page.mainFrame())->document());

}

void DeviceOrientationInspectorAgent::setDeviceOrientationOverride(ErrorString* error, double alpha, double beta, double gamma)