Change Page::m_mainFrame to be a Frame.

Change Page::m_mainFrame to be a Frame.

With OOPI, the main frame can be either local or remote. Features that depend
on the main frame being local will have to be updated to account for this fact.

This patch takes an aggressive approach--most locations that depend on main
frame being local have been updated to directly attempt to downcast to
LocalFrame, with no attempt to check that the main frame is local first. The
only places that check are those on the critical path towards getting
rendering/input events working with the updated OOPI infrastructure.

BUG=346764
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176162

[dcheng, 2014-06-15 00:21:00]

Fairly cookie cutter change. Basically, all calls to Page::mainFrame() got
wrapped in toLocalFrame() calls. I've also added Frame::isLocalFrame checks on
code paths that I believe are critical to bootstrapping the OOPI
infrastructure--I've opted to just let everything else crash instead of adding
checks that will be obsoleted anyway once the code has been adapted to work with
OOPI.

[abarth-chromium, 2014-06-15 00:33:11]

https://codereview.chromium.org/336553003/diff/20001/Source/bindings/v8/PageS...
File Source/bindings/v8/PageScriptDebugServer.cpp (right):

https://codereview.chromium.org/336553003/diff/20001/Source/bindings/v8/PageS...
Source/bindings/v8/PageScriptDebugServer.cpp:112: // FIXME: Broken for OOPI.
Rather than having a comment everywhere, can we add a function on page to
document this?

page->deprecatedLocalMainFrame()

?  Then we can grep for all the callers and drive them to zero.

[dcheng, 2014-06-15 02:58:34]

https://codereview.chromium.org/336553003/diff/20001/Source/bindings/v8/PageS...
File Source/bindings/v8/PageScriptDebugServer.cpp (right):

https://codereview.chromium.org/336553003/diff/20001/Source/bindings/v8/PageS...
Source/bindings/v8/PageScriptDebugServer.cpp:112: // FIXME: Broken for OOPI.
On 2014/06/15 00:33:11, abarth wrote:
> Rather than having a comment everywhere, can we add a function on page to
> document this?
> 
> page->deprecatedLocalMainFrame()
> 
> ?  Then we can grep for all the callers and drive them to zero.

Done.

[abarth-chromium, 2014-06-15 03:46:15]

I didn't review all the diffs, but I read through many of them.  LGTM

https://codereview.chromium.org/336553003/diff/40001/Source/core/page/Page.h
File Source/core/page/Page.h (right):

https://codereview.chromium.org/336553003/diff/40001/Source/core/page/Page.h#...
Source/core/page/Page.h:133: LocalFrame* deprecatedLocalMainFrame() const {
return toLocalFrame(m_mainFrame.get()); }
I would probably add a comment explaining why this function is deprecated and
what someone should do instead of calling it.

[dcheng, 2014-06-15 05:05:44]

https://codereview.chromium.org/336553003/diff/40001/Source/core/page/Page.h
File Source/core/page/Page.h (right):

https://codereview.chromium.org/336553003/diff/40001/Source/core/page/Page.h#...
Source/core/page/Page.h:133: LocalFrame* deprecatedLocalMainFrame() const {
return toLocalFrame(m_mainFrame.get()); }
On 2014/06/15 03:46:15, abarth wrote:
> I would probably add a comment explaining why this function is deprecated and
> what someone should do instead of calling it.

Done.

[dcheng, 2014-06-15 05:09:46]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-06-15 05:17:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dcheng@chromium.org/336553003/80001

[commit-bot: I haz the power, 2014-06-15 06:26:42]

Change committed as 176162