Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5906)

Unified Diff: chrome/browser/net/predictor.h

Issue 336543003: Add AllowNetworkPrediction preference name and enum. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address msg2. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/pref_names.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/predictor.h
diff --git a/chrome/browser/net/predictor.h b/chrome/browser/net/predictor.h
index 3234e17c71d3c02cdb167d2e08d8b84ae015951e..040fbd5237ba491a50572e59c305496d6119adea 100644
--- a/chrome/browser/net/predictor.h
+++ b/chrome/browser/net/predictor.h
@@ -609,6 +609,15 @@ class SimplePredictor : public Predictor {
virtual void ShutdownOnUIThread() OVERRIDE;
};
+// enum describing when to allow network predictions based on connection type.
jkarlin 2014/06/13 14:09:09 Comments should be complete sentences (with capita
Bence 2014/06/20 13:38:46 Done.
+// The same enum must be used by the platform-dependent UI components.
+// TODO(bnc) implement as per crbug.com/334602.
jkarlin 2014/06/13 14:09:09 don't forget the ':', TODO(bnc):
Bence 2014/06/20 13:38:46 Done.
+enum NetworkPredictionOptions {
jkarlin 2014/06/13 14:09:09 Please move the enum into the Predictor class in p
Bence 2014/06/20 13:38:46 Done.
+ NETWORK_PREDICTION_ALWAYS,
+ NETWORK_PREDICTION_WIFI_ONLY,
+ NETWORK_PREDICTION_NEVER
+};
+
} // namespace chrome_browser_net
#endif // CHROME_BROWSER_NET_PREDICTOR_H_
« no previous file with comments | « no previous file | chrome/common/pref_names.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698