Add AllowNetworkPrediction preference name and enum.

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/basictypes.h"
 #include "chrome/common/pref_font_webkit_names.h"
 
 namespace prefs {
@@ skipping 479 matching lines @@
 // 2: Browser window preferences migrated: kDevToolsSplitLocation and
 //    kBrowserWindowPlacement
 const char kMultipleProfilePrefMigration[] =
     "local_state.multiple_profile_prefs_version";
 
 // A boolean pref set to true if prediction of network actions is allowed.
 // Actions include DNS prefetching, TCP and SSL preconnection, prerendering
 // of web pages, and resource prefetching.
 // NOTE: The "dns_prefetching.enabled" value is used so that historical user
 // preferences are not lost.
+// NOTE: This will be obsoleted per issue 334602.

[jkarlin, 2014/06/13 11:26:40]

Replace above with TODO(bnc): Remove kNetworkPredictionEnabled once
kAllowNetworkPrediction is functioning as per crbug.com/334602.

[Bence, 2014/06/13 13:49:06]

Done.

 const char kNetworkPredictionEnabled[] = "dns_prefetching.enabled";
 
+// An integer pref shows if prediction of network actions is allowed:
+// ALWAYS, NEVER, or WIFI_ONLY.

[jkarlin, 2014/06/13 11:26:40]

Suggest pointing to where the enum is defined
chrome::Predictor::NetworkPredictionOptions (after you move it) instead of
enumerating here.  That way we can change the values without updating this
comment.

[Bence, 2014/06/13 13:49:06]

Done.

+// Actions include DNS prefetching, TCP and SSL preconnection, prerendering
+// of web pages, and resource prefetching.
+// NOTE: This preference is not respected yet. See issue 334602.

[jkarlin, 2014/06/13 11:26:40]

Replace NOTE line above with:

TODO(bnc): Implement this preference as per crbug.com/334602.

[Bence, 2014/06/13 13:49:06]

Done.

+const char kAllowNetworkPrediction[] = "allow-network-prediction";
+
 // An integer representing the state of the default apps installation process.
 // This value is persisted in the profile's user preferences because the process
 // is async, and the user may have stopped chrome in the middle.  The next time
 // the profile is opened, the process will continue from where it left off.
 //
 // See possible values in external_provider_impl.cc.
 const char kDefaultAppsInstallState[] = "default_apps_install_state";
 
 // A boolean pref set to true if the Chrome Web Store icons should be hidden
 // from the New Tab Page and app launcher.
@@ skipping 1859 matching lines @@
 // "mapped_title" entries, detailing the bookmark target URL (if any), the title
 // given by the PartnerBookmarksProvider and either the user-visible renamed
 // title or an empty string if the bookmark node was removed.
 const char kPartnerBookmarkMappings[] = "partnerbookmarks.mappings";
 #endif
 
 // Whether DNS Quick Check is disabled in proxy resolution.
 const char kQuickCheckEnabled[] = "proxy.quick_check_enabled";
 
 }  // namespace prefs