Issue 336523003: Remove unused Mac platform code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336523003: Remove unused Mac platform code. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
jamesr, esprehn

CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-rendering, dstockwell, eae+blinkwatch, Eric Willigers, jchaffraix+rendering, leviw+renderwatch, Mike Lawther (Google), pdr., rjwright, rune+blink, shans, Steve Block, Timothy Loh, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove unused Mac platform code. Most of ColorMac.h is unused (except for one function, which is only used in one file, but seems general enough to remain). EmptyProtocolDefinitions.h is included only in one source file, which does not refer to either of the protocol definitions it provides. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176094

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -87 lines)			Patch
M	Source/core/rendering/RenderThemeChromiumMac.mm	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/platform/mac/ColorMac.h	View	1 chunk	+2 lines, -9 lines	0 comments	Download
M	Source/platform/mac/ColorMac.mm	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	Source/platform/mac/EmptyProtocolDefinitions.h	View	1 chunk	+0 lines, -43 lines	0 comments	Download
M	Source/platform/mac/ScrollAnimatorMac.mm	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/336523003/1

6 years, 6 months ago (2014-06-13 05:16:27 UTC) #3

Message was sent while issue was closed.

Change committed as 176094

Expand Messages | Collapse Messages