Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336523002: Sync TextTrackList.getTrackById IDL with spec and test it (Closed)

Created:
6 years, 6 months ago by philipj_slow
Modified:
6 years, 6 months ago
CC:
blink-reviews, nessy, arv+blink, philipj_slow, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, Inactive, vcarbune.chromium
Visibility:
Public.

Description

Sync TextTrackList.getTrackById IDL with spec and test it http://whatwg.org/html#texttracklist The test has also been submitted to web-platform-tests: https://github.com/w3c/web-platform-tests/pull/1058 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176089

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
A LayoutTests/media/track/opera/interfaces/TextTrackList/getTrackById.html View 1 chunk +16 lines, -0 lines 0 comments Download
A + LayoutTests/media/track/opera/interfaces/TextTrackList/getTrackById-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/TextTrackList.idl View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
philipj_slow
6 years, 6 months ago (2014-06-12 13:40:47 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 6 months ago (2014-06-12 16:46:10 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-12 18:57:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/336523002/1
6 years, 6 months ago (2014-06-12 18:57:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-12 19:01:02 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 19:01:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16547)
6 years, 6 months ago (2014-06-12 19:01:30 UTC) #7
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-12 19:16:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/336523002/1
6 years, 6 months ago (2014-06-12 19:17:47 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-12 19:18:40 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 19:19:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/16547)
6 years, 6 months ago (2014-06-12 19:19:10 UTC) #12
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 6 months ago (2014-06-13 07:28:18 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/336523002/1
6 years, 6 months ago (2014-06-13 07:29:08 UTC) #14
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 08:21:31 UTC) #15
Message was sent while issue was closed. 
Change committed as 176089

Powered by Google App Engine
This is Rietveld 408576698