Issue 336513003: Allow enabling 'ScreenOrientation' feature outside Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336513003: Allow enabling 'ScreenOrientation' feature outside Blink.

Created:
6 years, 6 months ago by Mikhail

Modified:
6 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, blink-reviews, Inactive, dglazkov+blink, jamesr, kenneth.r.christiansen

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Allow enabling 'ScreenOrientation' feature outside Blink. SSIA. This patch introduces the 'enableScreenOrientation()' setter to the WebRuntimeFeatures class, so that 'ScreenOrientation' feature can be enabled outside Blink.

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	Source/web/WebRuntimeFeatures.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	public/web/WebRuntimeFeatures.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

6 years, 6 months ago (2014-06-13 03:09:32 UTC) #2

Why do we want to allow enabling the ScreenOrientation feature outside of Blink?
 The description doesn't contain any information explaining why we want to make
this change.

Expand Messages | Collapse Messages