Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 336463002: Oilpan: Improve Oilpan support in EventContext and EventPath. (Closed)

Created:
6 years, 6 months ago by tkent
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Visibility:
Public.

Description

Oilpan: Improve Oilpan support in EventContext and EventPath. * TreeScopeEventContext Move to Oilpan heap. * WindowEvnetContext Declare as STACK_ALLOCATED(), and remove Persistent<>s. * EventPath Eliminate raw pointers. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176114

Patch Set 1 #

Total comments: 2

Patch Set 2 : FINAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -30 lines) Patch
M Source/core/events/EventPath.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/events/EventPath.cpp View 8 chunks +9 lines, -7 lines 0 comments Download
M Source/core/events/NodeEventContext.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/events/NodeEventContext.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/events/TreeScopeEventContext.h View 1 3 chunks +12 lines, -11 lines 0 comments Download
M Source/core/events/TreeScopeEventContext.cpp View 2 chunks +13 lines, -3 lines 0 comments Download
M Source/core/events/WindowEventContext.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
tkent
Please review this.
6 years, 6 months ago (2014-06-12 05:27:35 UTC) #1
haraken
LGTM https://codereview.chromium.org/336463002/diff/1/Source/core/events/TreeScopeEventContext.h File Source/core/events/TreeScopeEventContext.h (right): https://codereview.chromium.org/336463002/diff/1/Source/core/events/TreeScopeEventContext.h#newcode46 Source/core/events/TreeScopeEventContext.h:46: class TreeScopeEventContext : public RefCountedWillBeGarbageCollected<TreeScopeEventContext> { Add FINAL.
6 years, 6 months ago (2014-06-12 05:51:43 UTC) #2
tkent
https://codereview.chromium.org/336463002/diff/1/Source/core/events/TreeScopeEventContext.h File Source/core/events/TreeScopeEventContext.h (right): https://codereview.chromium.org/336463002/diff/1/Source/core/events/TreeScopeEventContext.h#newcode46 Source/core/events/TreeScopeEventContext.h:46: class TreeScopeEventContext : public RefCountedWillBeGarbageCollected<TreeScopeEventContext> { On 2014/06/12 05:51:43, ...
6 years, 6 months ago (2014-06-12 06:24:49 UTC) #3
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-12 06:24:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/336463002/20001
6 years, 6 months ago (2014-06-12 06:26:00 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-12 07:27:47 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 09:00:58 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/11690)
6 years, 6 months ago (2014-06-12 09:00:59 UTC) #8
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-13 15:20:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/336463002/20001
6 years, 6 months ago (2014-06-13 15:20:38 UTC) #10
commit-bot: I haz the power
6 years, 6 months ago (2014-06-13 15:43:22 UTC) #11
Message was sent while issue was closed. 
Change committed as 176114

Powered by Google App Engine
This is Rietveld 408576698