Issue 336443004: Add components/keyed_service to GN build.

Issue 336443004: Add components/keyed_service to GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 5 months ago

Reviewers:
tfarina, blundell

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add components/keyed_service to GN build. BUG= R=blundell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278514

Patch Set 3 : no android #

Total comments: 4

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -0 lines)			Patch
M	BUILD.gn	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	components/keyed_service.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	components/keyed_service/content/BUILD.gn	View		1 chunk	+34 lines, -0 lines	0 comments	Download
A	components/keyed_service/core/BUILD.gn	View		1 chunk	+25 lines, -0 lines	4 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blundell

LGTM https://codereview.chromium.org/336443004/diff/20001/components/keyed_service.gypi File components/keyed_service.gypi (right): https://codereview.chromium.org/336443004/diff/20001/components/keyed_service.gypi#newcode8 components/keyed_service.gypi:8: # GN version: //components/keyed_service/core:core What does this syntax ...

6 years, 6 months ago (2014-06-19 20:19:01 UTC) #2

brettw

https://codereview.chromium.org/336443004/diff/20001/components/keyed_service.gypi File components/keyed_service.gypi (right): https://codereview.chromium.org/336443004/diff/20001/components/keyed_service.gypi#newcode8 components/keyed_service.gypi:8: # GN version: //components/keyed_service/core:core On 2014/06/19 20:19:01, blundell wrote: ...

6 years, 6 months ago (2014-06-19 20:21:23 UTC) #3

brettw

Committed patchset #3 manually as r278514 (presubmit successful).

6 years, 6 months ago (2014-06-19 22:45:32 UTC) #4

tfarina

6 years, 5 months ago (2014-06-28 20:12:46 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/336443004/diff/40001/components/keyed_service...
File components/keyed_service/core/BUILD.gn (right):

https://codereview.chromium.org/336443004/diff/40001/components/keyed_service...
components/keyed_service/core/BUILD.gn:5: component("keyed_service_core") {
Brett, didn't you mean s/keyed_service_core/core here?

So when depending on this target one could do "//components/keyed_service/core",
instead of "//components/keyed_service/core:keyed_service_core

https://codereview.chromium.org/336443004/diff/40001/components/keyed_service...
components/keyed_service/core/BUILD.gn:7: sources = [
blank line above.

https://codereview.chromium.org/336443004/diff/40001/components/keyed_service...
components/keyed_service/core/BUILD.gn:17: if (is_win) {
blank line above.

https://codereview.chromium.org/336443004/diff/40001/components/keyed_service...
components/keyed_service/core/BUILD.gn:17: if (is_win) {
I usually put conditions after deps.

Expand Messages | Collapse Messages