Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 336433003: Clobber frame_data->device_scale_factor to 1 on Android. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove readback scale, add other crbug Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_view_android.h" 5 #include "content/browser/renderer_host/render_widget_host_view_android.h"
6 6
7 #include <android/bitmap.h> 7 #include <android/bitmap.h>
8 8
9 #include "base/android/sys_utils.h" 9 #include "base/android/sys_utils.h"
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 674 matching lines...) Expand 10 before | Expand all | Expand 10 after
685 ui::WindowAndroidCompositor* compositor = 685 ui::WindowAndroidCompositor* compositor =
686 content_view_core_->GetWindowAndroid()->GetCompositor(); 686 content_view_core_->GetWindowAndroid()->GetCompositor();
687 DCHECK(compositor); 687 DCHECK(compositor);
688 DCHECK(frame_provider_); 688 DCHECK(frame_provider_);
689 scoped_refptr<cc::DelegatedRendererLayer> delegated_layer = 689 scoped_refptr<cc::DelegatedRendererLayer> delegated_layer =
690 cc::DelegatedRendererLayer::Create(frame_provider_); 690 cc::DelegatedRendererLayer::Create(frame_provider_);
691 delegated_layer->SetBounds(content_size_in_layer_); 691 delegated_layer->SetBounds(content_size_in_layer_);
692 delegated_layer->SetHideLayerAndSubtree(true); 692 delegated_layer->SetHideLayerAndSubtree(true);
693 delegated_layer->SetIsDrawable(true); 693 delegated_layer->SetIsDrawable(true);
694 delegated_layer->SetContentsOpaque(true); 694 delegated_layer->SetContentsOpaque(true);
695 gfx::Transform layer_scale(
696 device_scale_factor, 0.f, 0.f, device_scale_factor, 0.f, 0.f);
697 delegated_layer->SetTransform(layer_scale);
698 compositor->AttachLayerForReadback(delegated_layer); 695 compositor->AttachLayerForReadback(delegated_layer);
699 696
700 readback_layer = delegated_layer; 697 readback_layer = delegated_layer;
701 request = cc::CopyOutputRequest::CreateRequest( 698 request = cc::CopyOutputRequest::CreateRequest(
702 base::Bind(&RenderWidgetHostViewAndroid:: 699 base::Bind(&RenderWidgetHostViewAndroid::
703 PrepareTextureCopyOutputResultForDelegatedReadback, 700 PrepareTextureCopyOutputResultForDelegatedReadback,
704 dst_size_in_pixel, 701 dst_size_in_pixel,
705 bitmap_config, 702 bitmap_config,
706 start_time, 703 start_time,
707 readback_layer, 704 readback_layer,
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 resource_collection_->SetClient(NULL); 784 resource_collection_->SetClient(NULL);
788 if (resource_collection_->LoseAllResources()) 785 if (resource_collection_->LoseAllResources())
789 SendReturnedDelegatedResources(last_output_surface_id_); 786 SendReturnedDelegatedResources(last_output_surface_id_);
790 resource_collection_ = NULL; 787 resource_collection_ = NULL;
791 } 788 }
792 DestroyDelegatedContent(); 789 DestroyDelegatedContent();
793 790
794 last_output_surface_id_ = output_surface_id; 791 last_output_surface_id_ = output_surface_id;
795 } 792 }
796 793
794 // DelegatedRendererLayerImpl applies the inverse device_scale_factor of the
795 // renderer frame, assuming that the browser compositor will scale
796 // it back up to device scale. But on Android we put our browser layers in
797 // physical pixels and set our browser CC device_scale_factor to 1, so this
798 // suppresses the transform. This line may need to be removed when fixing
799 // http://crbug.com/384134 or http://crbug.com/310763
800 frame_data->device_scale_factor = 1.0f;
801
797 if (!has_content) { 802 if (!has_content) {
798 DestroyDelegatedContent(); 803 DestroyDelegatedContent();
799 } else { 804 } else {
800 if (!resource_collection_.get()) { 805 if (!resource_collection_.get()) {
801 resource_collection_ = new cc::DelegatedFrameResourceCollection; 806 resource_collection_ = new cc::DelegatedFrameResourceCollection;
802 resource_collection_->SetClient(this); 807 resource_collection_->SetClient(this);
803 } 808 }
804 if (!frame_provider_ || 809 if (!frame_provider_ ||
805 texture_size_in_layer_ != frame_provider_->frame_size()) { 810 texture_size_in_layer_ != frame_provider_->frame_size()) {
806 RemoveLayers(); 811 RemoveLayers();
807 frame_provider_ = new cc::DelegatedFrameProvider( 812 frame_provider_ = new cc::DelegatedFrameProvider(
808 resource_collection_.get(), frame_data.Pass()); 813 resource_collection_.get(), frame_data.Pass());
809 layer_ = cc::DelegatedRendererLayer::Create(frame_provider_); 814 layer_ = cc::DelegatedRendererLayer::Create(frame_provider_);
810 AttachLayers(); 815 AttachLayers();
811 } else { 816 } else {
812 frame_provider_->SetFrameData(frame_data.Pass()); 817 frame_provider_->SetFrameData(frame_data.Pass());
813 } 818 }
814 } 819 }
815 820
816 if (layer_.get()) { 821 if (layer_.get()) {
817 layer_->SetIsDrawable(true); 822 layer_->SetIsDrawable(true);
818 layer_->SetContentsOpaque(true); 823 layer_->SetContentsOpaque(true);
819 layer_->SetBounds(content_size_in_layer_); 824 layer_->SetBounds(content_size_in_layer_);
820 layer_->SetNeedsDisplay(); 825 layer_->SetNeedsDisplay();
821 // DelegatedRendererLayer scales the frame data from physical space to DIPs
822 // by inverting the frame's device scale factor, assuming that the browser
823 // compositor will map from DIPs back to physical pixels using its own
824 // device scale factor. However, the Android browser compositor always uses
825 // a device scale factor of 1.0, so we have to transform the delegated
826 // layer by the device scale to get it into the same physical pixel space as
827 // the rest of the UI.
828 const gfx::Display& display =
829 gfx::Screen::GetNativeScreen()->GetPrimaryDisplay();
830 float device_scale_factor = display.device_scale_factor();
831 gfx::Transform layer_scale(
832 device_scale_factor, 0.f, 0.f, device_scale_factor, 0.f, 0.f);
833 layer_->SetTransform(layer_scale);
834 } 826 }
835 827
836 base::Closure ack_callback = 828 base::Closure ack_callback =
837 base::Bind(&RenderWidgetHostViewAndroid::SendDelegatedFrameAck, 829 base::Bind(&RenderWidgetHostViewAndroid::SendDelegatedFrameAck,
838 weak_ptr_factory_.GetWeakPtr(), 830 weak_ptr_factory_.GetWeakPtr(),
839 output_surface_id); 831 output_surface_id);
840 832
841 ack_callbacks_.push(ack_callback); 833 ack_callbacks_.push(ack_callback);
842 if (host_->is_hidden()) 834 if (host_->is_hidden())
843 RunAckCallbacks(); 835 RunAckCallbacks();
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
1449 results->availableRect = display.work_area(); 1441 results->availableRect = display.work_area();
1450 results->deviceScaleFactor = display.device_scale_factor(); 1442 results->deviceScaleFactor = display.device_scale_factor();
1451 results->orientationAngle = display.RotationAsDegree(); 1443 results->orientationAngle = display.RotationAsDegree();
1452 gfx::DeviceDisplayInfo info; 1444 gfx::DeviceDisplayInfo info;
1453 results->depth = info.GetBitsPerPixel(); 1445 results->depth = info.GetBitsPerPixel();
1454 results->depthPerComponent = info.GetBitsPerComponent(); 1446 results->depthPerComponent = info.GetBitsPerComponent();
1455 results->isMonochrome = (results->depthPerComponent == 0); 1447 results->isMonochrome = (results->depthPerComponent == 0);
1456 } 1448 }
1457 1449
1458 } // namespace content 1450 } // namespace content
OLDNEW
« no previous file with comments | « android_webview/browser/hardware_renderer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698