Issue 336423004: enterprise.platformKeys: Cleanup the API test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 336423004: enterprise.platformKeys: Cleanup the API test. (Closed)

Created:
6 years, 6 months ago by pneubeck (no reviews)

Modified:
6 years, 6 months ago

Reviewers:
dconnelly

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

enterprise.platformKeys: Cleanup the API test. Adds also a few additional checks. BUG=385143 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278080

Patch Set 2 : Updated comment. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -30 lines)			Patch
	M	chrome/test/data/extensions/api_test/enterprise_platform_keys.crx	View	1	Binary file		0 comments	Download
	M	chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js	View	1	9 chunks	+34 lines, -30 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dconnelly

lgtm https://codereview.chromium.org/336423004/diff/40001/chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js File chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js (right): https://codereview.chromium.org/336423004/diff/40001/chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js#newcode289 chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js:289: // Ensure that this algorithm object is not ...

6 years, 6 months ago (2014-06-18 07:48:11 UTC) #2

pneubeck (no reviews)

The CQ bit was checked by pneubeck@chromium.org

6 years, 6 months ago (2014-06-18 08:49:08 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pneubeck@chromium.org/336423004/60001

6 years, 6 months ago (2014-06-18 08:52:13 UTC) #4

Message was sent while issue was closed.

Change committed as 278080

Expand Messages | Collapse Messages

Issue 336423004: enterprise.platformKeys: Cleanup the API test. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : Updated comment. #

Messages