Issue 336413006: Chrome suggestions are no longer served if the user doesn't sync his history on a given machine

Issue 336413006: Chrome suggestions are no longer served if the user doesn't sync his history on a given machine (Closed)

Created:
6 years, 6 months ago by beaudoin

Modified:
6 years, 6 months ago

Reviewers:
Mathieu, Jered

CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, dominich, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ensure that chrome suggestions are never served if the user doesn't sync his history on a given machine, even if he syncs it on other machines. BUG=384913 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278111

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 4

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Patch Set 7 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -6 lines)			Patch
M	chrome/browser/ui/search/search_ipc_router.h	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper.cc	View	1 2 3 4	3 chunks	+17 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/search/search_tab_helper_unittest.cc	View	1 2 3 4 5 6	9 chunks	+50 lines, -4 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

beaudoin

Hey Mathieu, Jered, A quick fix for a potential privacy issue with Chrome suggestions.

6 years, 6 months ago (2014-06-17 22:09:33 UTC) #1

Mathieu

lgtm https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_tab_helper.cc File chrome/browser/ui/search/search_tab_helper.cc (right): https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_tab_helper.cc#newcode541 chrome/browser/ui/search/search_tab_helper.cc:541: // The identity check only passes if the ...

6 years, 6 months ago (2014-06-17 22:26:31 UTC) #2

beaudoin

https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_tab_helper.cc File chrome/browser/ui/search/search_tab_helper.cc (right): https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_tab_helper.cc#newcode541 chrome/browser/ui/search/search_tab_helper.cc:541: // The identity check only passes if the user ...

6 years, 6 months ago (2014-06-17 22:33:03 UTC) #3

Jered

lgtm This seems safe. https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_ipc_router.h File chrome/browser/ui/search/search_ipc_router.h (right): https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_ipc_router.h#newcode81 chrome/browser/ui/search/search_ipc_router.h:81: // matches and the user ...

6 years, 6 months ago (2014-06-17 22:38:19 UTC) #4

beaudoin

https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_ipc_router.h File chrome/browser/ui/search/search_ipc_router.h (right): https://codereview.chromium.org/336413006/diff/60001/chrome/browser/ui/search/search_ipc_router.h#newcode81 chrome/browser/ui/search/search_ipc_router.h:81: // matches and the user syncs his history. On ...

6 years, 6 months ago (2014-06-18 13:49:04 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/beaudoin@chromium.org/336413006/110001

6 years, 6 months ago (2014-06-18 13:49:33 UTC) #7

Message was sent while issue was closed.

Change committed as 278111

Expand Messages | Collapse Messages