base/logging.h - Issue 336413005: [Android] Spill out CHECK error message in official build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/logging.h

Issue 336413005: [Android] Spill out CHECK error message in official build (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: update commit message Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/logging.h

diff --git a/base/logging.h b/base/logging.h

index bc97ae156a6dc9d8f294a3b420c8e0f0bea782f8..1a110a565e9f89e77278eee31fdfcf42d0f3a223 100644

--- a/base/logging.h

+++ b/base/logging.h

@@ -433,7 +433,7 @@ const LogSeverity LOG_0 = LOG_ERROR;

// We make sure CHECK et al. always evaluates their arguments, as

// doing CHECK(FunctionWithSideEffect()) is a common idiom.

-#if defined(OFFICIAL_BUILD) && defined(NDEBUG)

+#if defined(OFFICIAL_BUILD) && defined(NDEBUG) && !defined(OS_ANDROID)

// Make all CHECK functions discard their log strings to reduce code

// bloat for official release builds.

« no previous file with comments | « no previous file | no next file » | no next file with comments »